Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Sending email notifications after editing time expires. And user setting for offline digest/notification frequency. #7088

Closed
wants to merge 17 commits into from

Conversation

Projects
None yet
2 participants
@pkgodara
Copy link
Contributor

commented May 25, 2017

Closes #6506, #6079, #854

  • Administrator Setting to able/disable 'Sending updated message Notifications after editing time expires'.

Above feature works only if "Allow Message Editing" is set true & "Block Message Editing After (n) Minutes" is set to Non-zero value.

pr 6506

  • Digest frequency for users in preferences.

This feature will work regardless of anything but have something else [See Comment].

pr 6506-2

@pkgodara pkgodara changed the title Sending email notifications after editing time expires. [NEW] Sending email notifications after editing time expires. May 25, 2017

@pkgodara pkgodara changed the title [NEW] Sending email notifications after editing time expires. [NEW] Sending email notifications after editing time expires. And user setting for offline digest/notification frequency. May 31, 2017

@pkgodara

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2017

Information regarding second feature:

Digest frequency would work independently but duplicate email notifications would be there.

So, to avoid duplicate notifications, these administrator settings are compulsory:

  1. "Allow Message Editing" is set true.
  2. "Block Message Editing After (n) Minutes" is set to Non-zero value (let say x minutes).
    3. "Sending Email Notifications after editing time expires" is set true.

If these settings are there, users will have x minutes to read messages & email notifications will not be sent for those messages.

@RocketChat RocketChat deleted a comment from codacy-bot Jun 14, 2017

@RocketChat RocketChat deleted a comment from codacy-bot Jun 14, 2017

@RocketChat RocketChat deleted a comment from codacy-bot Jun 14, 2017

@RocketChat RocketChat deleted a comment from codacy-bot Jun 14, 2017

@RocketChat RocketChat deleted a comment from codacy-bot Jun 14, 2017

@Flasheur111

This comment has been minimized.

Copy link

commented Jul 20, 2017

I think this feature would be awesome. That would make sense to let the users get those notifications via email. Are you planning to rebase this PR with the latest code soon ?

@pkgodara pkgodara closed this Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.