Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select option don't toggle on clicking the close icon #417

Merged
merged 3 commits into from
Apr 20, 2021
Merged

fix: Select option don't toggle on clicking the close icon #417

merged 3 commits into from
Apr 20, 2021

Conversation

PriyaBihani
Copy link
Contributor

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Previously

Screen.Recording.2021-03-27.at.7.21.48.AM.mov

Now

Screen.Recording.2021-03-27.at.7.20.51.AM.mov

Issue(s)

#412

Further comments

@PriyaBihani
Copy link
Contributor Author

@gabriellsh can you take a look ..

@tiagoevanp tiagoevanp changed the title [FIX]Select: option don't toggle on clicking the close icon fix: Select: option don't toggle on clicking the close icon Apr 19, 2021
@tiagoevanp tiagoevanp changed the title fix: Select: option don't toggle on clicking the close icon fix: Select option don't toggle on clicking the close icon Apr 19, 2021
@ggazzo ggazzo merged commit 4401d94 into RocketChat:develop Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants