-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pulling each pokemons IVs and Moves by starting their encounter. #1272
Merged
Merged
Changes from 26 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
55dbd18
Scan for IVs and moves
MangoScango 6777297
Don't ignore moves.json
MangoScango f7ea31e
whoopsie tabsies
MangoScango bbfdc22
im on a roll here
MangoScango 3bb6484
whitespace is really hard guys
MangoScango 66ba9da
whitespace is really hard guys
MangoScango b7c9bf9
Merge branch 'IVs-and-Moves' of https://github.com/MangoScango/Pokemo…
MangoScango 78540cc
I'm sorry travis senpai
MangoScango fd26a1b
Don't pass the whole dictonary to pokemonLabel on top of everything else
MangoScango 99b6351
Notifications based off % perfection
MangoScango 1bd8939
praise travis
MangoScango 0dd3c3e
Fix 0/0/0 results from atypical spawnpoints?
MangoScango 72f1dcf
Merge upstream
MangoScango 5dc897d
minor text fixes
MangoScango 046d8f6
Merge remote-tracking branch 'refs/remotes/origin/develop' into IVs-a…
MangoScango bbfb6e3
Merge remote-tracking branch 'refs/remotes/PokemonGoMap/develop' into…
MangoScango 697f7f4
Fix get_encountered_pokemon
MangoScango 5c367ff
Default to a whitelist, support a black one
MangoScango 6618816
Stop erroneous empty results when rescanning pokemon
MangoScango 0bb01f5
Minor text fixes
MangoScango 2421e33
Minorer text fixes
MangoScango 4e62f39
No more white/black flip
MangoScango ef2a900
Fix up the white/blacklists
MangoScango d3510bb
sorry travis
MangoScango 083b94a
derp
MangoScango 673cc30
leave me alone travis
MangoScango 8c7e345
Improve moves.json handling
MangoScango aff3407
Reduce db requests to one per cell
MangoScango dcec218
text minor fixes
MangoScango d97aae7
Handle failed encounters
MangoScango be16e9b
Merge remote-tracking branch 'refs/remotes/PokemonGoMap/develop' into…
MangoScango 0ba3212
Minor fixes to the config.ini.example
primaxius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be optimized? This query in loop can get hit multiple times, and with millions of pokemon in db maybe intense? would it be better as single query? me and @jchristi thought maybe something like this? I know also encounter_id is not guaranteed to be unique.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated my gist. We need to b64encode the encounter_id again when creating encountered_pokemon and also need to account for when encounter_ids is empty. See this PR: https://github.com/PokemonGoMap/PokemonGo-Map/pull/1303/files#diff-541e2b217ba4a7d7859dae2cb443b6b7L585