Enable pulling each pokemons IVs and Moves by starting their encounter. #1272

MangoScango · 2016-09-11T21:00:57Z

Description

Adds 4 options:
--encounter (-enc) will enable the map to start encounters to gather IVs and movesets for each pokemon
--encounter-delay (-ed) sets the delay in seconds between finding a pokemon and encountering it defaults to 1, must be bigger than 0 to avoid rate limiting.
--encounter-whitelist (-ewht) is a whitelist of pokemon to encounter.
--encounter-blacklist (-eblk) is a blacklist of pokemon to not encounter.

Be very careful with this. Each pokemon you encounter will send an entirely new request, potentially doubling the amount of requests your server makes. Don't spam Niantic about every Pidgey in your city, please. Use one of these lists to filter out unwanted pokemon.

The database gets bumped to 8, and gains 'individual_attack', 'individual_defense', 'individual_stamina', 'move_1', and 'move_2' in the pokemon table. Where the IVs are just the ints you'd expect, and the moves are numbers we look up in the JSON file provided. All of these stats are passed on to the webhook,

The map shows percent of perfection each pokemon has, as well as its IVs and moves. It also features notifications for exceptional pokemon, using #1187 's implementation.

It's based heavily on #332. I mostly just fixed the merge issues and squashed some bugs.

A somewhat major change I made is now before each pokemon is parsed, I query the database to see if any active spawns with that encounter_id are already in there, and if so I skip them entirely. This is to avoid having to re encounter any pokemon that get scanned multiple times, otherwise the new stats would be wiped once the pokemon was reinserted. I then bump a new 'skipped' variable, and add that count when we log how many pokemon we found to avoid people seeing false '0' results.

Oh, and the gitignore was updated so I could add moves.json

Motivation and Context

Lots of people are clamoring for this. Hopefully we can get it in before SafteyNet ruins the party.

How Has This Been Tested?

Tested on my own machine, running a spawnpoint scan of about 1800 spawnpoints into a MySQL database. There have been various other people testing this as well, in the other PR threads. #1187 #1239 .

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

Clean implementation, bug free?

…nGo-Map into IVs-and-Moves

From owraight's branch

Some spawnpoints spawn the same encounter multiple times an hour. This should prevent those points from being skipped over in the parsing process.

(and no, that last commit doesn't seem to fix the empty results.)

…nd-Moves

… IVs-and-Moves

oops. Thanks sLoPPydrive.

Keep track of of pokemon that get skipped over druing the parsing phase so we don't think we're getting 0 results from the server.

azd2 · 2016-09-11T21:22:43Z

Finally, thanks for opening your own PR!
Hope this makes it into official then.
For testing purposes i'm going to start from scratch, seem to be some changes in since i pulled my running installation 2 or 3 days ago from your repo.
Going to post how it went tomorrow then.

Lukiido · 2016-09-11T22:45:01Z

Is --encounter-list (-elst) comma separated in the config.ini?

MangoScango · 2016-09-11T22:50:30Z

@Lukiido yep. Same logic as the usernames list. Not happy with the way it works via cli though, you have to specify each item individually.

Would it be better to take a string and split that into a list?

Lukiido · 2016-09-11T22:53:34Z

@MangoScango maybe something like pokealarm, where its alarm,json and you set values for true or false if you want IV's checked. Might be better.

MangoScango · 2016-09-12T00:39:32Z

@Lukiido Not a fan of that. We have config file already. No need for something else. Just not sure if it's better to take that arg as a list (since it is a list) or a string (since it would make the cli less obnoxious).

justsomedudeonthenet · 2016-09-12T00:49:49Z

So some thoughts on this, having looked over the code:

Specifying Pokemon to Scan

There has been much discussion about how to determine which ones to scan. I really don't like having encounter-blacklist flip the list's meaning.

My proposal would be to have --encounter-whitelist and --encounter-blacklist as mutually exclusive arguments (you can only specify one, trying to enter both throws an error). I think that would be less confusing for everyone, and give the flexibility to people who want to scan almost all pokemon or only a few.

Webhooks

I recall there being something floating around to patch PokeAlarm to handle IVs. Does changing the webhooks break the default PokeAlarm install? Or does it gracefully ignore the extra data?

Database

Love that you have changed it to add fields to the pokemon table instead of using a separate table.

If I'm reading it right, whether or not this feature is enabled, it will stop re-inserting pokemon that already exist in the table?

That's great! I do wonder what kind of performance impact it will have on people using remote databases though, since it's going to make a query to check for each pokemon each time. Definitely better than rescanning them though.

MangoScango · 2016-09-26T14:28:05Z

I believe it's merge ready. I think FrostFox mentioned the plan was to do it after the API is updated. Patience.

MJ869 · 2016-09-26T20:29:58Z

So the plan is to merge and make latest commit and zip file available as soon as 0.35 API is shut down?

FrostTheFox · 2016-09-27T01:15:01Z

Asking when it's going to be merged isn't going to help in getting it merged. We've done extensive testing of this PR, and yes, it's likely not going to get pulled in until after the API is cracked again.

When it is cracked, it will definitely be our top priority.

FrostTheFox · 2016-09-27T01:16:22Z

Also, keep the support in here as low as possible. PRs are not meant to be used for support. If it gets to the point where it's nothing productive towards the PR, I'll have to lock it to contribs.

primaxius · 2016-09-27T05:12:01Z

Multiple users have tested this, I have tested and ran into 0 issues. DB locks can happen if your hardware/DB is not powerful/configured properly.

galaxy9999 · 2016-09-27T07:58:52Z

I typed git fetch origin pull/1272/head:"IVS" in my develop map folder. I got fatal: Not a git repository (or any of the parent directories): git

How do I fix that? Thank you!

MangoScango · 2016-09-28T11:05:46Z

🎉

* Update pokemon.json (RocketMap#1305) * Matches Polyfill (RocketMap#1100) * Update index.rst (RocketMap#1322) updated windows link for nodejs, was 4.4.7 move to 4.5.0 * Move commandline page from wiki to docs (RocketMap#1326) Reorganizing to keep docs in docs * fixes (RocketMap#1327) There! More example.py * Added Title to command line page and misc fix (RocketMap#1335) * webworker (RocketMap#1287) * Output better error when csv file has > 3 fields (RocketMap#1336) * Correct multi-acc doc * Prevent header from cutting off bottom (RocketMap#1343) Same issue/fix as RocketMap#873, this time affecting the stats side bar instead of the menu bar * Close info window upon second click (RocketMap#1238) Currently the info window for Pokémon, Gyms, etc. can only be closed with the little x. This adds a stateful click handler that closes the info window with a second click. Implements RocketMap#1237 * Decrease Number of Upserted Rows (RocketMap#1091) * Decrease step size * Check the type of DB * setup.bat now won't set paths if already set, now also installs npm (RocketMap#770) * Various fixes Updated to install npm and now includes more user output. Now also won't set paths if already set, which was a problem if you ran the setup more than once. * Update setup.bat * Updated to not use temp files As requested by Balthamel, it now no longer uses a temp file but rathers stores it in a variable. * Update the "Easy setup" script (RocketMap#1217) * Fully Implement On Demand Mode(Conflicts resolved) (RocketMap#1271) * On demand mode * On demand mode * On demand mode * On demand mode * Pause before checking time in service * Fix alphabetical order (RocketMap#1110) * Suppress virtual keyboard - update - mobile OS detection (RocketMap#1289) * [Fix] issue RocketMap#622, statistics 2x Uncaught TypeError * Fix lint errors * Prevent OSK on Touch * Select Boxes prevent Virtual Keyboard Appearing on Touch Devices * remove unnecessary loop * basic mobile os detection * fixed order in which some things must be installed * Fix for some cases of 0,0,0 returns (RocketMap#1097) Some users reporting 0,0,0 returns on subsequent auth token refreshes after the first. * Update pull request template (RocketMap#399) * Update pull request template * Changed checklist into a comment * Stupid markdown comments * Auth Update for nginx.md (RocketMap#221) * Auth Update for nginx.md Adding large block for httpd nginx authentication with reverse proxy * Update nginx.md * Removed references to third party docker container (RocketMap#1359) * Removed references to third party container * Changed references to container we control * SpawnPoint Scanning Confusion - changed --spawnpoints-only to --skip-empty (RocketMap#1372) * Change --spawnpoints-only to --skip-empty Change --spawnpoints-only to --skip-empty with better description in order to stop the confusion between TBTerra's Spawnpoint Scanning and this. * Update commandline.md to include --skip-empty * Few doc updates (RocketMap#1373) * Added little Linux thing * Some doc updates * little thing * changed 2nd gen link * added loc gen * Enhance Statistics Panel (RocketMap#1241) * Test Commit * Revert "Test Commit" aa This reverts commit e87c9d5. * Add sortable Pokemon stats table * Put back accidentally deleted PokeGyms stats code * add link to Pokedex * Styling fixes for statistics panel * Fix listing errors * fix some PokéSpelling errors * Only count visible pokemon/gyms/pokestops Correct issue (that has apparently existed for a while?) where items not currently on screen were included in the stats. * fix linting errors * add option to specify config file on command line or via env variable RocketMap#1341 - Rebased (RocketMap#1376) * add option to specify config file on command line or via env variable original PR 1341 * Add new config file documentation Original PR 1341 * Update commandline.md with new config file flags Original PR 1341 * fix for those not using a config file at all (RocketMap#1377) * Fixed purge_data query not executing (RocketMap#1247) * Escaping ampersand in html (RocketMap#1380) It's groundbreaking. My valid html OCD is kicking in again :D * Add gym levels to markers (alternative to RocketMap#351) and misc gym marker upgrades (RocketMap#782) * Added gym levels to marker icons Relocated code for determining gym levels to a new function getGymLevel() * Gym Level Markers * Compressed changed files (4.9kb ->1.4kb) * Fixed ternary operator order You guys are right. I didn't even think of it * Made the gymPrestige array a global variable Made gymPrestige a global variable as opposed to a local variable in the event that other features use this data in the future (such as RocketMap#666) * Add gym style option * Choose between gym marker styles * lint fix * Reorganized forts for multiple gym styles * Reload icons on demand Used to wait until a mapUpdate(), but that could take up to 5 seconds * Fixed lint error * Lossless and optimized large versions Original large version had heavy artifacts and were not compressed. Harmony: 35.7KB -> 20.2KB Instinct: 17.6KB -> 10.1KB Mystic: 27.4KB -> 11.6KB Valor: 29.0KB -> 13.9KB Uncontested: 43.2KB -> 14.6KB * High-res gym markers for mobile When viewing on mobile, the images get enlarged in order to have the same "size" as when viewing on the desktop, resulting in blurry images * High-res gym markers for mobile Same thing as the ingame markers * Load and scale back a higher res version Mobile users will be able to load the markers without them being blurry * Whoops, didn't realize stats used these too * Changed default gym marker to in-game * Resize icons based on higher res icons * Revert default gym markers back to shield * Forgot these Somehow I forgot to upload these when I added the css for #arenaList :/ * we use sass, we can do crazy programatic stuff like this (RocketMap#1390) * [FAQ.md] Updated formula Thanks OurFlagIsMined :3 * Enable pulling each pokemons IVs and Moves by starting their encounter. (RocketMap#1272) * Scan for IVs and moves Clean implementation, bug free? * Don't ignore moves.json * whoopsie tabsies * im on a roll here * whitespace is really hard guys * whitespace is really hard guys * I'm sorry travis senpai * Don't pass the whole dictonary to pokemonLabel on top of everything else * Notifications based off % perfection From owraight's branch * praise travis * Fix 0/0/0 results from atypical spawnpoints? Some spawnpoints spawn the same encounter multiple times an hour. This should prevent those points from being skipped over in the parsing process. * minor text fixes * Fix get_encountered_pokemon oops. Thanks sLoPPydrive. * Default to a whitelist, support a black one * Stop erroneous empty results when rescanning pokemon Keep track of of pokemon that get skipped over druing the parsing phase so we don't think we're getting 0 results from the server. * Minor text fixes * Minorer text fixes * No more white/black flip --encounter-blacklist (-eblk) is back, and --encounter-whitelist (-ewht) is here now. * Fix up the white/blacklists Now they're in a mutually exclusive group, and it properly encounter everything if neither list is set. * sorry travis * derp * leave me alone travis * Improve moves.json handling Use RocketMap#1316 more useful moves.json and support move names being translated * Reduce db requests to one per cell Instead of one per pokemon. Thanks jchristi and DiscoTim * text minor fixes * Handle failed encounters * Minor fixes to the config.ini.example

…o be parsed again.

…r. (RocketMap#1272) * Scan for IVs and moves Clean implementation, bug free? * Don't ignore moves.json * whoopsie tabsies * im on a roll here * whitespace is really hard guys * whitespace is really hard guys * I'm sorry travis senpai * Don't pass the whole dictonary to pokemonLabel on top of everything else * Notifications based off % perfection From owraight's branch * praise travis * Fix 0/0/0 results from atypical spawnpoints? Some spawnpoints spawn the same encounter multiple times an hour. This should prevent those points from being skipped over in the parsing process. * minor text fixes * Fix get_encountered_pokemon oops. Thanks sLoPPydrive. * Default to a whitelist, support a black one * Stop erroneous empty results when rescanning pokemon Keep track of of pokemon that get skipped over druing the parsing phase so we don't think we're getting 0 results from the server. * Minor text fixes * Minorer text fixes * No more white/black flip --encounter-blacklist (-eblk) is back, and --encounter-whitelist (-ewht) is here now. * Fix up the white/blacklists Now they're in a mutually exclusive group, and it properly encounter everything if neither list is set. * sorry travis * derp * leave me alone travis * Improve moves.json handling Use RocketMap#1316 more useful moves.json and support move names being translated * Reduce db requests to one per cell Instead of one per pokemon. Thanks jchristi and DiscoTim * text minor fixes * Handle failed encounters * Minor fixes to the config.ini.example

@DiscoTim

…n' Pokémon in the JSON from server to client. (#1303) * Only send 'not-hidden' pokemon * Forgot to take out console.log * More space fixes * Bye redundant pokestop requests. Hi, travis? * <3 Travis * one more commit, should really test before push * When moving screen only send new pokestops + modified * Yes, spaces indentations and empty lines.. * And again.. * And another.. * Dont query each ID but remove ID's we dont send afterwards. * Check if Stops/Gyms go from off to on, use same old/previous coords for both Gyms/Stops and use optional parameters in get_stops/get_gyms instead of new function * Spaces indents and you know whats. * Only send updated and newly visible Stops/Gyms and not-'hidden' Pokemon. * Query datetime instead of time * Clean exclude query. * over-indented * Only send modified pokemon and uncovered. * Fix list + list, instead of .update * Default value for last_modified * Optimize SQL queries * Code cleanup * Code from PR #1272, Pokémon already in database don't need to be parsed again. * Code fixes and optimising ScannedLocations * Fix if clause so pokemen get properly skipped. * A bridge too far, ScannedLocations dont update properly when only sending new locations (Reverting Scannedlocations changes) * Code fixes * Check for Gym last scanned instead of modified to update front-end Last Scanned value. * Code cleanup/optimization for app.py * refactor map.js to not require full data set for scanned locations and spawn points * Fix switch flip in between json updates * Optimize scannedlocations and spawnpoints * Random capitals and code fixes * Optimize map.js thanks @DiscoTim * Fix class so it works like it used to * Code clean up, prevstamp was not used * When zooming in we are not uncovering new terrain, so no need to look further then last_modified * # Comments to clarify * It needs some overlap * Determine last_modified on insert * Move timestanp generation up * Reduced the need for backtrack on timestamp Reduced the default response, no need for the previous status on switch if its false. Dont send the new fields in the response Collect all pokemon/forts from cells before running queries. Dont upsert pokestops that haven't changed since last scan. Show in log how many pokemon/pokestop we didnt upsert (skipped). Set scannedlocation last_modified on upsert instead of in code. Add extra column on pokestops to keep track of when its been updated so we can send it to the map. * update map.js to not require full set of pokestops * Minor text fixes * Frontend/Backend fixes Only send lured stops if lured-only is selected Resend unhidden Pokes * Minor map fix * Minor text fixes. * Send all pokemon details to frontend * Small woopsie oh baby, oh baby, prepare for disappointment ;P -Thunderfox

tegob · 2016-10-03T11:21:26Z

@MangoScango Do you think the /stats page should show IV information as well?

MangoScango · 2016-10-03T11:25:38Z

@tegob as far as I can tell, IVs and moves are distributed normally. A
15/15/15 is the same probability as 0/0/0. So there's no interesting
information to show.

On Mon, Oct 3, 2016, 7:21 AM tegob notifications@github.com wrote:

@MangoScango https://github.com/MangoScango Do you think the /stats
page should show IV information as well?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PokemonGoMap/PokemonGo-Map/pull/1272#issuecomment-251082937,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHRT_t4yb2gfZlrfvLj6-94lx0pEchLHks5qwOVBgaJpZM4J6Gmr
.

CalcMan · 2016-10-03T17:13:29Z

@MangoScango my use case for stats page showing IVs and moves is less about aggregate statistics and more about "what did I just catch?", so if I know I caught, say a Snorlax at this location, I might be able to figure out its IVs by calculation, but that map /knows/ what the IVs were, so I could just look it up.

Similar the the spawn point history PR (#1412) that's in the works.

renxida · 2016-10-04T17:19:49Z

Wiki Update?

The webhook wiki does not have the IVs. I know nothing about github wikis. Can somebody fix/teach me how to fix it?

MangoScango · 2016-10-05T15:11:03Z

@CalcMan Ohh. Yeah, I love that idea. Sadly I just started a second job, so
I won't have time to work on anything here for awhile.

On Tue, Oct 4, 2016 at 1:20 PM RADiEnCe notifications@github.com wrote:

Wiki Update?

The webhook wiki does not have the IVs. I know nothing about github wikis.
Can somebody fix/teach me how to fix it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PokemonGoMap/PokemonGo-Map/pull/1272#issuecomment-251453419,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHRT_s91LCDuoJdM-puJCavo3rTugZ6gks5qworAgaJpZM4J6Gmr
.

@DiscoTim

* Update pokemon.json (RocketMap#1305) * Matches Polyfill (RocketMap#1100) * Update index.rst (RocketMap#1322) updated windows link for nodejs, was 4.4.7 move to 4.5.0 * Move commandline page from wiki to docs (RocketMap#1326) Reorganizing to keep docs in docs * fixes (RocketMap#1327) There! More example.py * Added Title to command line page and misc fix (RocketMap#1335) * webworker (RocketMap#1287) * Output better error when csv file has > 3 fields (RocketMap#1336) * Correct multi-acc doc * Prevent header from cutting off bottom (RocketMap#1343) Same issue/fix as RocketMap#873, this time affecting the stats side bar instead of the menu bar * Close info window upon second click (RocketMap#1238) Currently the info window for Pokémon, Gyms, etc. can only be closed with the little x. This adds a stateful click handler that closes the info window with a second click. Implements RocketMap#1237 * Decrease Number of Upserted Rows (RocketMap#1091) * Decrease step size * Check the type of DB * setup.bat now won't set paths if already set, now also installs npm (RocketMap#770) * Various fixes Updated to install npm and now includes more user output. Now also won't set paths if already set, which was a problem if you ran the setup more than once. * Update setup.bat * Updated to not use temp files As requested by Balthamel, it now no longer uses a temp file but rathers stores it in a variable. * Update the "Easy setup" script (RocketMap#1217) * Fully Implement On Demand Mode(Conflicts resolved) (RocketMap#1271) * On demand mode * On demand mode * On demand mode * On demand mode * Pause before checking time in service * Fix alphabetical order (RocketMap#1110) * Suppress virtual keyboard - update - mobile OS detection (RocketMap#1289) * [Fix] issue RocketMap#622, statistics 2x Uncaught TypeError * Fix lint errors * Prevent OSK on Touch * Select Boxes prevent Virtual Keyboard Appearing on Touch Devices * remove unnecessary loop * basic mobile os detection * fixed order in which some things must be installed * Fix for some cases of 0,0,0 returns (RocketMap#1097) Some users reporting 0,0,0 returns on subsequent auth token refreshes after the first. * Update pull request template (RocketMap#399) * Update pull request template * Changed checklist into a comment * Stupid markdown comments * Auth Update for nginx.md (RocketMap#221) * Auth Update for nginx.md Adding large block for httpd nginx authentication with reverse proxy * Update nginx.md * Removed references to third party docker container (RocketMap#1359) * Removed references to third party container * Changed references to container we control * SpawnPoint Scanning Confusion - changed --spawnpoints-only to --skip-empty (RocketMap#1372) * Change --spawnpoints-only to --skip-empty Change --spawnpoints-only to --skip-empty with better description in order to stop the confusion between TBTerra's Spawnpoint Scanning and this. * Update commandline.md to include --skip-empty * Few doc updates (RocketMap#1373) * Added little Linux thing * Some doc updates * little thing * changed 2nd gen link * added loc gen * Enhance Statistics Panel (RocketMap#1241) * Test Commit * Revert "Test Commit" aa This reverts commit e87c9d5. * Add sortable Pokemon stats table * Put back accidentally deleted PokeGyms stats code * add link to Pokedex * Styling fixes for statistics panel * Fix listing errors * fix some PokéSpelling errors * Only count visible pokemon/gyms/pokestops Correct issue (that has apparently existed for a while?) where items not currently on screen were included in the stats. * fix linting errors * add option to specify config file on command line or via env variable RocketMap#1341 - Rebased (RocketMap#1376) * add option to specify config file on command line or via env variable original PR 1341 * Add new config file documentation Original PR 1341 * Update commandline.md with new config file flags Original PR 1341 * fix for those not using a config file at all (RocketMap#1377) * Fixed purge_data query not executing (RocketMap#1247) * Escaping ampersand in html (RocketMap#1380) It's groundbreaking. My valid html OCD is kicking in again :D * Add gym levels to markers (alternative to RocketMap#351) and misc gym marker upgrades (RocketMap#782) * Added gym levels to marker icons Relocated code for determining gym levels to a new function getGymLevel() * Gym Level Markers * Compressed changed files (4.9kb ->1.4kb) * Fixed ternary operator order You guys are right. I didn't even think of it * Made the gymPrestige array a global variable Made gymPrestige a global variable as opposed to a local variable in the event that other features use this data in the future (such as RocketMap#666) * Add gym style option * Choose between gym marker styles * lint fix * Reorganized forts for multiple gym styles * Reload icons on demand Used to wait until a mapUpdate(), but that could take up to 5 seconds * Fixed lint error * Lossless and optimized large versions Original large version had heavy artifacts and were not compressed. Harmony: 35.7KB -> 20.2KB Instinct: 17.6KB -> 10.1KB Mystic: 27.4KB -> 11.6KB Valor: 29.0KB -> 13.9KB Uncontested: 43.2KB -> 14.6KB * High-res gym markers for mobile When viewing on mobile, the images get enlarged in order to have the same "size" as when viewing on the desktop, resulting in blurry images * High-res gym markers for mobile Same thing as the ingame markers * Load and scale back a higher res version Mobile users will be able to load the markers without them being blurry * Whoops, didn't realize stats used these too * Changed default gym marker to in-game * Resize icons based on higher res icons * Revert default gym markers back to shield * Forgot these Somehow I forgot to upload these when I added the css for #arenaList :/ * we use sass, we can do crazy programatic stuff like this (RocketMap#1390) * [FAQ.md] Updated formula Thanks OurFlagIsMined :3 * Enable pulling each pokemons IVs and Moves by starting their encounter. (RocketMap#1272) * Scan for IVs and moves Clean implementation, bug free? * Don't ignore moves.json * whoopsie tabsies * im on a roll here * whitespace is really hard guys * whitespace is really hard guys * I'm sorry travis senpai * Don't pass the whole dictonary to pokemonLabel on top of everything else * Notifications based off % perfection From owraight's branch * praise travis * Fix 0/0/0 results from atypical spawnpoints? Some spawnpoints spawn the same encounter multiple times an hour. This should prevent those points from being skipped over in the parsing process. * minor text fixes * Fix get_encountered_pokemon oops. Thanks sLoPPydrive. * Default to a whitelist, support a black one * Stop erroneous empty results when rescanning pokemon Keep track of of pokemon that get skipped over druing the parsing phase so we don't think we're getting 0 results from the server. * Minor text fixes * Minorer text fixes * No more white/black flip --encounter-blacklist (-eblk) is back, and --encounter-whitelist (-ewht) is here now. * Fix up the white/blacklists Now they're in a mutually exclusive group, and it properly encounter everything if neither list is set. * sorry travis * derp * leave me alone travis * Improve moves.json handling Use RocketMap#1316 more useful moves.json and support move names being translated * Reduce db requests to one per cell Instead of one per pokemon. Thanks jchristi and DiscoTim * text minor fixes * Handle failed encounters * Minor fixes to the config.ini.example * Doc fixes (RocketMap#1410) * Update commandline.md with IV commands * Added information for updating * Add scan here function (RocketMap#1398) * Add scan here function * fix tab for spaces * fix trailing space * adding a switch to show the scan button with a warning message the first time the switch is enabled * travis correction (replacing doublequotes by singlequotes) * deleted unwanted files * deleted unwanted files * Removed deprecated debug flag (RocketMap#1427) * Removed Debug flag * Removed debug to verbose condition * Removed a missed reference to debug flag. * Clarify `encounter-delay` unit (RocketMap#1423) It’s measured in seconds. * fix default config usage (RocketMap#1428) * Only send updated and newly visible Stops/Gyms/Pokémon and not-'hidden' Pokémon in the JSON from server to client. (RocketMap#1303) * Only send 'not-hidden' pokemon * Forgot to take out console.log * More space fixes * Bye redundant pokestop requests. Hi, travis? * <3 Travis * one more commit, should really test before push * When moving screen only send new pokestops + modified * Yes, spaces indentations and empty lines.. * And again.. * And another.. * Dont query each ID but remove ID's we dont send afterwards. * Check if Stops/Gyms go from off to on, use same old/previous coords for both Gyms/Stops and use optional parameters in get_stops/get_gyms instead of new function * Spaces indents and you know whats. * Only send updated and newly visible Stops/Gyms and not-'hidden' Pokemon. * Query datetime instead of time * Clean exclude query. * over-indented * Only send modified pokemon and uncovered. * Fix list + list, instead of .update * Default value for last_modified * Optimize SQL queries * Code cleanup * Code from PR RocketMap#1272, Pokémon already in database don't need to be parsed again. * Code fixes and optimising ScannedLocations * Fix if clause so pokemen get properly skipped. * A bridge too far, ScannedLocations dont update properly when only sending new locations (Reverting Scannedlocations changes) * Code fixes * Check for Gym last scanned instead of modified to update front-end Last Scanned value. * Code cleanup/optimization for app.py * refactor map.js to not require full data set for scanned locations and spawn points * Fix switch flip in between json updates * Optimize scannedlocations and spawnpoints * Random capitals and code fixes * Optimize map.js thanks @DiscoTim * Fix class so it works like it used to * Code clean up, prevstamp was not used * When zooming in we are not uncovering new terrain, so no need to look further then last_modified * # Comments to clarify * It needs some overlap * Determine last_modified on insert * Move timestanp generation up * Reduced the need for backtrack on timestamp Reduced the default response, no need for the previous status on switch if its false. Dont send the new fields in the response Collect all pokemon/forts from cells before running queries. Dont upsert pokestops that haven't changed since last scan. Show in log how many pokemon/pokestop we didnt upsert (skipped). Set scannedlocation last_modified on upsert instead of in code. Add extra column on pokestops to keep track of when its been updated so we can send it to the map. * update map.js to not require full set of pokestops * Minor text fixes * Frontend/Backend fixes Only send lured stops if lured-only is selected Resend unhidden Pokes * Minor map fix * Minor text fixes. * Send all pokemon details to frontend * Small woopsie oh baby, oh baby, prepare for disappointment ;P -Thunderfox * Update last modified on already existing scanlocations and fixes 1448 (RocketMap#1444) * Update last modified on already existing scanlocations * references before filled * Handle default config file in configargparse correctly (RocketMap#1463) * fix default config usage * fix issue w/ configargparse not reading default value * update debian instillation (RocketMap#1432) * update debian instillation updated for easier instillation for noobs like me :) * update debian instillation added cd~/ * Update linux.rst * Update linux.rst (RocketMap#1483) Fedora fix for: error: command 'gcc' failed with exit status 1 and on Fedora needs only: dnf install python * Update example.py * Update example.py * Updated readme * Fixed travis errors, map still not working * Fix map V.2 (RocketMap#1511) * Fixed the null pointer error again * Use official API * Updated for new libs, added submodule and updated docs (RocketMap#1522) * remove IRC from readme * Enable automated recaptcha solving with 2captcha (RocketMap#1526) * Enable automatic captcha solving via 2captcha * Revert "Enable automatic captcha solving via 2captcha" This reverts commit 39dd8e4. * Enable automated captcha solving with 2captcha -cs flag to enable -ck flag to specify 2captcha API key -cds flag to specify the data-sitekey for PoGo captchas * Revert "Enable automated captcha solving with 2captcha" This reverts commit 13c10cf. * Enable automated captcha solving with 2captcha -cs flag to enable -ck flag to specify 2captcha API key -cds flag to specify the data-sitekey for PoGo captchas * Revert "Enable automated captcha solving with 2captcha" This reverts commit c1286a6. * Enable automated captcha solving with 2captcha -cs flag to enable -ck flag to specify 2captcha API key -cds flag to specify the data-sitekey for PoGo captchas * Uncommented 'api.activate_signature(encryption_lib_path)' * Travis fixes * Update for .45 API (RocketMap#1536) * Remove unneeded encrypt lib references and remove unneeded submodule * removed recursive instructions * cmon travis, I wanna go to sleep. * Travis, let me sleep. It's 3:44am. * Whoops, forgot to remove this * Remove direct node download links Not needed, another thing to needlessly update. Points to main nodejs download now. * Somebody managed to get none-CI passing code into develop? (RocketMap#1563) * Change searchbox into Autocomplete object. (RocketMap#1270) * Change searchbox into Autocomplete object. Autocomplete fields are more flexible than Searchbox: http://goo.gl/pxqxK7 This will enable Autocomplete results to be limited to countries, coordinate bounds, etc. Requested in RocketMap#1129 * Check if `place` contains `geometry`. When user doesn't choose a place from the dropdown, there's a console error due to missing `geomerty` property. * *grumble, grumble* (I actually love Travis).

@DiscoTim

…n' Pokémon in the JSON from server to client. (RocketMap#1303) * Only send 'not-hidden' pokemon * Forgot to take out console.log * More space fixes * Bye redundant pokestop requests. Hi, travis? * <3 Travis * one more commit, should really test before push * When moving screen only send new pokestops + modified * Yes, spaces indentations and empty lines.. * And again.. * And another.. * Dont query each ID but remove ID's we dont send afterwards. * Check if Stops/Gyms go from off to on, use same old/previous coords for both Gyms/Stops and use optional parameters in get_stops/get_gyms instead of new function * Spaces indents and you know whats. * Only send updated and newly visible Stops/Gyms and not-'hidden' Pokemon. * Query datetime instead of time * Clean exclude query. * over-indented * Only send modified pokemon and uncovered. * Fix list + list, instead of .update * Default value for last_modified * Optimize SQL queries * Code cleanup * Code from PR RocketMap#1272, Pokémon already in database don't need to be parsed again. * Code fixes and optimising ScannedLocations * Fix if clause so pokemen get properly skipped. * A bridge too far, ScannedLocations dont update properly when only sending new locations (Reverting Scannedlocations changes) * Code fixes * Check for Gym last scanned instead of modified to update front-end Last Scanned value. * Code cleanup/optimization for app.py * refactor map.js to not require full data set for scanned locations and spawn points * Fix switch flip in between json updates * Optimize scannedlocations and spawnpoints * Random capitals and code fixes * Optimize map.js thanks @DiscoTim * Fix class so it works like it used to * Code clean up, prevstamp was not used * When zooming in we are not uncovering new terrain, so no need to look further then last_modified * # Comments to clarify * It needs some overlap * Determine last_modified on insert * Move timestanp generation up * Reduced the need for backtrack on timestamp Reduced the default response, no need for the previous status on switch if its false. Dont send the new fields in the response Collect all pokemon/forts from cells before running queries. Dont upsert pokestops that haven't changed since last scan. Show in log how many pokemon/pokestop we didnt upsert (skipped). Set scannedlocation last_modified on upsert instead of in code. Add extra column on pokestops to keep track of when its been updated so we can send it to the map. * update map.js to not require full set of pokestops * Minor text fixes * Frontend/Backend fixes Only send lured stops if lured-only is selected Resend unhidden Pokes * Minor map fix * Minor text fixes. * Send all pokemon details to frontend * Small woopsie oh baby, oh baby, prepare for disappointment ;P -Thunderfox

MangoScango added 21 commits September 8, 2016 23:08

Scan for IVs and moves

55dbd18

Clean implementation, bug free?

Don't ignore moves.json

6777297

whoopsie tabsies

f7ea31e

im on a roll here

bbfdc22

whitespace is really hard guys

3bb6484

whitespace is really hard guys

66ba9da

Merge branch 'IVs-and-Moves' of https://github.com/MangoScango/Pokemo…

b7c9bf9

…nGo-Map into IVs-and-Moves

I'm sorry travis senpai

78540cc

Don't pass the whole dictonary to pokemonLabel on top of everything else

fd26a1b

Notifications based off % perfection

99b6351

From owraight's branch

praise travis

1bd8939

Fix 0/0/0 results from atypical spawnpoints?

0dd3c3e

Some spawnpoints spawn the same encounter multiple times an hour. This should prevent those points from being skipped over in the parsing process.

Merge upstream

72f1dcf

(and no, that last commit doesn't seem to fix the empty results.)

minor text fixes

5dc897d

Merge remote-tracking branch 'refs/remotes/origin/develop' into IVs-a…

046d8f6

…nd-Moves

Merge remote-tracking branch 'refs/remotes/PokemonGoMap/develop' into…

bbfb6e3

… IVs-and-Moves

Fix get_encountered_pokemon

697f7f4

oops. Thanks sLoPPydrive.

Default to a whitelist, support a black one

5c367ff

Stop erroneous empty results when rescanning pokemon

6618816

Keep track of of pokemon that get skipped over druing the parsing phase so we don't think we're getting 0 results from the server.

Minor text fixes

0bb01f5

Minorer text fixes

2421e33

MangoScango closed this Sep 11, 2016

MangoScango reopened this Sep 11, 2016

MangoScango mentioned this pull request Sep 11, 2016

Get IVs for each discovered Pokemon and allow notification for high IVs #1187

Closed

6 tasks

springjools mentioned this pull request Sep 26, 2016

[Feature Request] Changelog #1388

Closed

Minor fixes to the config.ini.example

0ba3212

primaxius removed the pending changes label Sep 27, 2016

primaxius approved these changes Sep 27, 2016

View reviewed changes

primaxius assigned FrostTheFox Sep 27, 2016

FrostTheFox merged commit 9b3927e into RocketMap:develop Sep 28, 2016

Darkknightz pushed a commit to Darkknightz/PokemonGo-Map that referenced this pull request Sep 28, 2016

Code from PR RocketMap#1272, Pokémon already in database don't need t…

7cd7529

…o be parsed again.

renxida mentioned this pull request Oct 3, 2016

Only send updated and newly visible Stops/Gyms/Pokémon and not-'hidde… renxida/PokemonGo-Map#1

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable pulling each pokemons IVs and Moves by starting their encounter. #1272

Enable pulling each pokemons IVs and Moves by starting their encounter. #1272

MangoScango commented Sep 11, 2016 •

edited

azd2 commented Sep 11, 2016

Lukiido commented Sep 11, 2016

MangoScango commented Sep 11, 2016

Lukiido commented Sep 11, 2016

MangoScango commented Sep 12, 2016

justsomedudeonthenet commented Sep 12, 2016

MangoScango commented Sep 26, 2016

MJ869 commented Sep 26, 2016 •

edited

FrostTheFox commented Sep 27, 2016

FrostTheFox commented Sep 27, 2016

primaxius commented Sep 27, 2016

galaxy9999 commented Sep 27, 2016

MangoScango commented Sep 28, 2016

tegob commented Oct 3, 2016

MangoScango commented Oct 3, 2016

CalcMan commented Oct 3, 2016 •

edited

renxida commented Oct 4, 2016

MangoScango commented Oct 5, 2016

Enable pulling each pokemons IVs and Moves by starting their encounter. #1272

Enable pulling each pokemons IVs and Moves by starting their encounter. #1272

Conversation

MangoScango commented Sep 11, 2016 • edited

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

azd2 commented Sep 11, 2016

Lukiido commented Sep 11, 2016

MangoScango commented Sep 11, 2016

Lukiido commented Sep 11, 2016

MangoScango commented Sep 12, 2016

justsomedudeonthenet commented Sep 12, 2016

Specifying Pokemon to Scan

Webhooks

Database

MangoScango commented Sep 26, 2016

MJ869 commented Sep 26, 2016 • edited

FrostTheFox commented Sep 27, 2016

FrostTheFox commented Sep 27, 2016

primaxius commented Sep 27, 2016

galaxy9999 commented Sep 27, 2016

MangoScango commented Sep 28, 2016

tegob commented Oct 3, 2016

MangoScango commented Oct 3, 2016

CalcMan commented Oct 3, 2016 • edited

renxida commented Oct 4, 2016

MangoScango commented Oct 5, 2016

MangoScango commented Sep 11, 2016 •

edited

MJ869 commented Sep 26, 2016 •

edited

CalcMan commented Oct 3, 2016 •

edited