Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morning session: Peer to peer review #2

Open
smunozmo opened this issue Jul 27, 2021 · 0 comments
Open

Morning session: Peer to peer review #2

smunozmo opened this issue Jul 27, 2021 · 0 comments

Comments

@smunozmo
Copy link

smunozmo commented Jul 27, 2021

Hi @RokoVarano

Good job so far! 👽

  • Maybe put the API key inside a .env, so it doesn't be in the middle of code.
  • Instead of refreshing the role page after gathering the value, change those fields and clear the input
.

Your code looks great, there's nothing else to say, time to merge!

Happy coding! 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant