Update-Zweihander-Grim-&-Perilous #4914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting Uptodate
Updating My Branch
HTML changed from Table format to a Grid Format. Lots of Attribute names were changed sheet workers used to migrate old data to new Attribute names. CSS Updated for Grid. Sheetworkers Updated. Translations Added.
Translation Additions Banner breakdown for changes CSS update
|
Adding the comment" nogileyelsew should be congratulated for all of the hard work they put in without my input. Thank you |
clevett
approved these changes
Apr 10, 2019
|
I just did the update to the Zweihander sheet and I notice that I need a file for translations. I'm not sure if I was supposed to do this or not. I thought that the en translation would automatically be populated. Any Insight would be appreciated, Wes |
|
The files will automatically be generated if a translation.json is included. I think the issue here is the file you included is translations.json with an "s". You can submit a PR to rename this file and come Tuesday when I run the translation process again it should update. Thanks, |
|
Thank you. I will do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Comments
This update is a major Overhaul to the Zweihander Grim & Perilous character sheet.
• Changed the HTML table format to HTML/CSS Grid
• Added Translation Support
• Rewrote a large portion of the Sheetworkers to make them more Efficient
• 95% of the attributes were changed to a lowercase naming scheme.
• 75% of the roll buttons were renamed to meet a lowercase naming scheme.
• HTML Titles were used to label each attributes and roll button name on mouse hover.
• Sheet workers were used to migrate the attribute values in both regular and repeating sections. None
of the old values have been erased.
• Added a version check for upgrading.
• Condensed multiple roll templates to one and added functionality for D100 dice mechanics.
• Roll 20 wiki page is being constructed to track all of the changes to the attributes and roll buttons.
• A banner was created for the top of the character sheet informing users of the changes and how to
proceed with using the updated sheet.
Roll20 Requests
Include the name of the sheet(s) you made changes to in the title.
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.
If you do not know English. Please leave a comment in your native language.