Harry potter Character Sheet - Skill Default Values #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the Display issue reported on the forums.
Warning about about an upcoming upgrade and uploading images in preparation for migrating code to point to github instead of my private website (as much as possible)
Update My Fork from Master
Rewrote the sheet from the ground up. The sheet has been completely redesigned (with feedback from the user community). The sheet includes a sheet worker to migrate old character datat to the new format. Internationalization is supported
Sheet neon updated with missing commas
Added more missing commas to sheet.json
See Title
Need to update my branch from Roll20 Master
Need to update my Branch
Fixed various bugs. Added enhancements to better support SWADE. Made changes to aid useability.
A few fields and roll formulae were missing the data-i18n tags. Corrected the ones I could find.
Providing the ability to rename skills
Need to update my fork to match the R20 Master
Bug fixes and internationalization of the default Sheet Settings
Needed to change the attribute name for Power and Robot Armor strength. Implemented a sheetworker to migrate the values from the old attribute to the new.
Added support for Gritty Damage, as well as a Statblock output button. Also fixed several bugs.
Updated the info rolltemplate so if people want to use ability command buttons, the buttons are styled rather than the default large pink button.
Skill rolls were throwing up an error when the skill field was blank. Added a default value of 0.
|
You have some changes to Savage Worlds as well, are they intentional? |
|
No, but what are you seeing? Because when I look at the changes in the pull request, all I see are the Harry Potter changes? |
clevett
approved these changes
May 20, 2019
Anduh
reviewed
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Comments
Added Default Values to the skills so the skill rolls wouldn't produce an error.
Roll20 Requests
Include the name of the sheet(s) you made changes to in the title.
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.
If you do not know English. Please leave a comment in your native language.