Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sponge platform (server and client) #230

Closed
Rollczi opened this issue Oct 10, 2023 · 3 comments · Fixed by #372
Closed

Support Sponge platform (server and client) #230

Rollczi opened this issue Oct 10, 2023 · 3 comments · Fixed by #372
Assignees
@BlackBaroness
Labels
hacktoberfest This year we’re celebrating 11 years of open source love! https://hacktoberfest.com/ platform

Comments

@Rollczi
Copy link
Owner

Rollczi commented Oct 10, 2023

https://github.com/SpongePowered/SpongeAPI
@Rollczi Rollczi added hacktoberfest This year we’re celebrating 11 years of open source love! https://hacktoberfest.com/ platform labels Oct 10, 2023
@Rollczi Rollczi changed the title Support Sponge platform Support Sponge platform (server and client) Oct 10, 2023
@BlackBaroness
Copy link
Contributor

I will do this

@BlackBaroness
Copy link
Contributor

@Rollczi

@Rollczi
Copy link
Owner Author

Rollczi commented Oct 18, 2023

I will do this

Okey

This was referenced Feb 2, 2024
Closed
Merged
Rollczi added a commit that referenced this issue Feb 8, 2024
@BlackBaroness @Rollczi
GH-230 Implement Sponge platform support (#372)
157f605 
* Implement Sponge platform support

* Clean up build gradle.

* Separate suggester and parser for components.

* Add kick example, add binds for server and client.

* Fix bug with command suggestions and parsing multiline completions. Don't for-loop for unhook command.

* InvalidUsageHandlerImpl -> InvalidUsageMessage. Fix sponge repo url. Add todo note.

* Clean up examples. Follow @vLuckyyy suggestions.

* Simplify server player suggester.

* Change visibility sponge platform and sponge command to package-private.

* Change visibility sponge platform public.

---------

Co-authored-by: Rollczi <ndejlich5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BlackBaroness BlackBaroness

Labels
hacktoberfest This year we’re celebrating 11 years of open source love! https://hacktoberfest.com/ platform
Projects
LiteCommands
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-230 Implement Sponge platform support BlackBaroness/LiteCommands
Add Sponge platform support
2 participants
@Rollczi @BlackBaroness