-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-230 Implement Sponge platform support #372
GH-230 Implement Sponge platform support #372
Conversation
…on't for-loop for unhook command.
@BlackBaroness Thanks for your pull request. I tested all changes and fixed a few issues. There is also a new example of kick command 😸. Check out the new changes and give me your feedback if everything is okay with my changes (I don't have any experiences with the sponge platform. |
Everything looks good (I don't use Sponge either btw) Did you test it? I believe I had errors when |
Yeah, you are right. Sponge does not support package-private classes :/. I will fix that. |
Closes #230
Hi, sorry for being super late!
Here is a Sponge 8 support (it's the latest stable API, included in all modern Sponge builds).
I added a
ServerPlayer
argument,ServerPlayer
contextual and test/tp <player> [player]
command. You can test it yourself using./gradlew :examples:sponge:runServer
. I also wanted to add a/gm
command, but Sponge has... special... API design and I couldn't understand how to make proper suggestions (but the parsing was relatively fine). However, I believe it's enough for this platform.It's the newly opened version of my previous PR. Changes in this one:
ServerPlayerArgument
andServerPlayerOnlyContextual
automatically, just like in Bukkit platformMessageKey
system to handle argument/contextual messages instead of using legacy contructor variantServerPlayerOnlyContextual
returnServerPlayer
, notPlayer