Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with saving deployments #400

Closed
annavik opened this issue Jun 6, 2024 · 3 comments
Closed

Some issues with saving deployments #400

annavik opened this issue Jun 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working frontend

Comments

@annavik
Copy link
Member

annavik commented Jun 6, 2024

Comments from user testing:

  • When creating a deployment, the validation error does not tell you which fields need to be filled in (just shows a 400 error)
  • Need to "Save" deployment to update cached values, but can’t save without changing a field (so we currently add a period, etc. to the Description field)
  • Manual captures doesn't update cached values (or regroup sessions) when done
@annavik annavik added bug Something isn't working frontend labels Jun 6, 2024
@annavik
Copy link
Member Author

annavik commented Jun 6, 2024

Some thoughts:

  • The first problem is possibly related to the wizard layout. If an error occurs in a form step that is currently not active, this is not visible to the user, which is not optimal. My suggestion would probably be to save each step individually, but let's discuss.
  • The second problem I think we should fix by never have the save button disabled (also see Inconsistency on edit and save #398). But I'm also curious about the cached values, can you explain what happened here @mihow ?

@annavik annavik self-assigned this Jun 10, 2024
@mihow
Copy link
Collaborator

mihow commented Jun 10, 2024

@annavik Thanks for defining this one. the cached values are updated whenever the Deployment is saved. So if the user can click Save then they will be updated. The problem has been with the image uploader. I don't want to update the cache on every image upload if the user uploads multiple. It would be nice to auto-save after a batch is uploaded. But also the user can just click Save to update the cache before closing the modal. Can we prevent the modal from being closed or show a warning if anything has been changed? Including manually uploaded captures?

@mihow
Copy link
Collaborator

mihow commented Jul 29, 2024

The Deployment cache is now updating correctly after #379. I will close and we can revisit any UI issues related to validation later on non-visible wizard tabs if they come up again.

@mihow mihow closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

2 participants