Web UI source images #162
Merged
Web UI source images #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(+ some mobile tweaks)
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kimf
approved these changes
Jun 2, 2023
|
Thanks so much for abstracting the image carousel component! That will be really useful. Also, the small screen version is mucho appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Comments:
Image carousel stuff looks new, but I have mostly extracted stuff from the current image table cell. As part of that, I have also made the component more dynamic. We can now give it any width (for example 100%) and specify image ratio instead of using fixed height. Before the slideshow required both fixed width and height.
Connection status and example captures is using mock data while waiting on BE. This PR focuses on preparing the UI.
Screenshots:
Connection status and example captures are now part of deployment details. We also show this in edit mode.
Connection status widget has 3 modes, one animated:
Layout tweaks for small screen version:
