Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce related entities #331

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Introduce related entities #331

merged 8 commits into from
Jan 17, 2024

Conversation

annavik
Copy link
Member

@annavik annavik commented Dec 5, 2023

Summary of changes:

  • Set up generic entity type (to use for storage, sites and devices)
  • Make it possible to list entities
  • Make it possible to create, update and delete entity
  • Setup entity dropdown component (to use in other forms, for example in deployment form)
  • Hook up deployment with new entities

Screenshots:
Screenshot 2023-12-11 at 23 13 11

Screenshot 2023-12-11 at 23 13 01 Screenshot 2023-12-11 at 23 17 34 Screenshot 2023-12-11 at 23 14 26

Notes for future:
The entity type is actually something we could reuse also for other objects and delete some code! All objects seems to have at least id, name, created at, updated at and user permissions?

Also, after starting to extend the entity model for other objects, we can replace the pipeline picker completely with the newly created entity picker.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit d184095
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/657788a215bbde0008a72aba
😎 Deploy Preview https://deploy-preview-331--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 66
Accessibility: 100
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit d184095
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/657788a281eea800082605ce
😎 Deploy Preview https://deploy-preview-331--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annavik
Copy link
Member Author

annavik commented Dec 6, 2023

I have started try hook up site and device with deployment, I'm keeping it simple for now. Is it something like this you had in mind?

Screenshot 2023-12-06 at 11 42 28 Screenshot 2023-12-06 at 11 42 37

If so, can we make BE accept device_id and site_id on deployment create and patch? And return device and site in deployment details response (including both id and name). @mihow

Next up: data source!

@annavik annavik changed the title [Draft]: Introduce entities Introduce entities Dec 11, 2023
@annavik annavik marked this pull request as ready for review December 11, 2023 22:18
@annavik
Copy link
Member Author

annavik commented Dec 11, 2023

PR is updated with storage entity. Also we can connect entities to deployments now. I have updated PR desc and marked for ready for review, please give it a test run when you get a chance :) @mihow

@mihow mihow changed the title Introduce entities Introduce related entities Dec 12, 2023
@mihow mihow merged commit 8f02271 into main Jan 17, 2024
6 checks passed
@mihow mihow deleted the web-ui-entities branch February 8, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants