Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing pre commit hook #396

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fix failing pre commit hook #396

merged 2 commits into from
Jun 10, 2024

Conversation

annavik
Copy link
Member

@annavik annavik commented Jun 5, 2024

No description provided.

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit aa80702
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/6667571e9fa4c10008d00bcb
😎 Deploy Preview https://deploy-preview-396--ami-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit aa80702
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/6667571e5e2a8400089b213d
😎 Deploy Preview https://deploy-preview-396--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annavik
Copy link
Member Author

annavik commented Jun 10, 2024

@mihow think I need some help with the pre-commit hook here 🙏 it works fine for me when I trigger locally!

Or we can disable lint check from pre-commit hook until we have a solution?

@annavik annavik self-assigned this Jun 10, 2024
@mihow
Copy link
Collaborator

mihow commented Jun 10, 2024

@annavik I tried a few things and failed! But now it looks like there is a different package that is more popular for frontend/React projects to run linting on pre-push, called Husky

I am removing Eslint from the pre-commit hook for now

@mihow mihow merged commit 04fe0d6 into main Jun 10, 2024
5 checks passed
@mihow mihow deleted the fix/eslint-pre-commit branch June 10, 2024 19:47
@annavik annavik added this to the Internal Beta V2 Release milestone Jun 17, 2024
@annavik annavik assigned mihow and unassigned annavik Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants