Fix deployment date labels #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mihow
approved these changes
Aug 4, 2024
There was a problem hiding this comment.
Thanks! I think the backend behavior is what is expected. If there are no images, then the first & last image dates of the deployment are null. When we have shared types then it will be easy to see which fields can be null!
"first_date": null,
"last_date": null,
mihow
added a commit
that referenced
this pull request
Aug 4, 2024
* Update layout to support new way to navigate captures * Setup session slider component + cleanup * Fix confidence threshold score bug * Adjust updated sidebar layout for smaller screens * Show active capture timestamp in slider * Update detection frame logic and tweak appearance * Show session activity in a chart and make timestamp slider fully interactive * New endpoint with data for Session Detail timeline component * Default the resolution minutes to 1, add validation * Ensure all source images don't have null detections * Fetch full timeline instead of capture page * Adjust hover labels * Adjust plot range based on session start and end * Skip line shape spline for now * Show capture info inline * Select first capture on session details load * Always snap to closest capture on slider commit * Add numCaptures to session timeline * Update detections & next/prev in captures endpoints: - Add next/prev captures to detail endpoint - Remove detections[] list from list view by default - Detections detail always has detections - Return all detections if classification_score param is not passed * Return all unfiltered detections for captures * Fix missing captures at end of timeline * Add detections count to session detail * Fix missing "detection scores" now that we are showing unfiltered detections * Add num detections to session detail view * Use newly available detection score property instead of workaround * Add current index of capture within event, update prop names * Update step navigation * Render capture stepper also during loading to avoid flickering * Do not allow line breaks for slider labels * Disable populate for starred collection (#478) * Fix deployment date labels (#481) * Limit top species to 10 in top species chart * Update allowed fields for ordering --------- Co-authored-by: Michael Bunsen <notbot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If deployment has no captures, we show no start or end labels. Workaround for #461 to avoid confusions in upcoming launch, but feel free to do a proper fix BE side when there is time :)