Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup web app for AMI Platform #74

Merged
merged 19 commits into from
Mar 10, 2023
Merged

Setup web app for AMI Platform #74

merged 19 commits into from
Mar 10, 2023

Conversation

annavik
Copy link
Member

@annavik annavik commented Mar 9, 2023 •
edited
Loading

In this PR we setup the AMI Platform web app. The setup includes:

  • Initialize React app using TypeScript
  • Add ESLint and Prettier
  • Prepare for unit testing with Jest
  • Add Sass support
  • Setup Storybook for visual documentation of the design system in code
  • Some simple layout, setup of style variables and two example components

More info can be found in ui/README.md.

@annavik annavik requested a review from mihow March 9, 2023 09:19
mihow
mihow approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Anna! My only thought is that we move everything from /root/ui/ami-platform into /root/ui. We may have to move things again, but for now that would be a nice simplification.

@annavik annavik merged commit c5706bd into main Mar 10, 2023
@annavik annavik deleted the web-ui branch March 10, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihow mihow mihow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annavik @mihow