Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evidence node not shown in the initial Network View #291

Closed
KeywanHP opened this issue Sep 5, 2018 · 2 comments
Closed

Evidence node not shown in the initial Network View #291

KeywanHP opened this issue Sep 5, 2018 · 2 comments
Assignees
Labels

Comments

@KeywanHP
Copy link
Member

KeywanHP commented Sep 5, 2018

Spotted an issue where a node that contains the search term in its attribute is not shown. A possible reason could be that the attribute is not indexed by Lucene.

The concept-name is: Storage 56 days
The attribute-name is: Study

Can be replicated on Arabidopsis or Wheat KnetMiner:
Keyword: germination
Gene List: MFT

The visualized network for MFT is missing the highlighted paths.

image

Following search shows the path:
Keyword: germination OR storage
Gene List: MFT

Conclusion: concept-name is OK; something wrong with concept-attribute.

@marco-brandizi please check if the "Indexed flag" is set to true for that specific node-attribute.

@KeywanHP KeywanHP added the bug label Sep 5, 2018
AjitPS added a commit that referenced this issue Feb 16, 2019
@marco-brandizi
Copy link
Member

@KeywanHP is this still relevant? Problem hasn't changed, "Storage 56 days" doesn't yield any result. I don't think we should mess-up with attributes around and add them up freely. We should try to harmonise things instead, that is:

  • the indexed/searched labels should be a stable, limited and well-known set of attributes (eg, name, description, maybe phenotype). If you have specific attributes that you want indexed, you should dublicate them as a common attribute.
  • "Study" is likely not a necessary attribute, doesn't correspond to any common practice (letting apart standard). Managing it with provenance or a Study/Experiment concept seems more appropriate.

@KeywanHP
Copy link
Member Author

The data and data model has changed and I can find keywords matching study attributes in KnetMiner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants