Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to saving of normalised spectra results #4

Open
stormnick opened this issue Jun 19, 2023 · 3 comments
Open

Suggestions to saving of normalised spectra results #4

stormnick opened this issue Jun 19, 2023 · 3 comments

Comments

@stormnick
Copy link

Hi,

Just a small suggestion. Perhaps it would be nice if the top column was saved with a #. Right now it is saved as wave flux normed_flux normed_error, which can cause TOPCAT (especially TOPCAT!) or np.loadtxt (without skiprows) to interpret it as part of the data and thus a string. Maybe changing it to the # wave flux normed_flux normed_error would make it a tiny bit easier to load normalised data without the need to specify first column as a comment every time? Cheers.

P.S. Thanks a lot for switching to PySide6, it works great on my Mac now.

@stormnick
Copy link
Author

Also to add to that, another potential suggestion: when the input spectra has nan values at some wavelengths, suppnet only saves two columns for those wavelengths (wavelength and not sure what, I guess normalisation error?). It would be nice if it would save 4 columns regardless (makes it easier to read by other programs once again). I don't particularly care if those columns also become nan or 0, but that would simplify usage for input spectra with nan values. Thanks!

@stormnick stormnick changed the title Save top row as a comment Suggestions to saving of normalised spectra results Jun 19, 2023
@stormnick
Copy link
Author

And maybe one last thing, it would be great if I could choose whether to save the flux column. I don't always care about flux in my normalised spectra file, because I have flux in the original file as well. When I do the fitting, I mostly care about normalised flux. It would be cool to have an option to not save flux, and just have two (three) main columns: wavelength normalised_flux error. Just a suggestion as well. Cheers!

@RozanskiT
Copy link
Owner

Thank you for all the feedback! 👍 I'll take a look, how much problems would it cause to add a "#" sign in the beginning of the header and then consider this. The second and third comment will be addressed, as soon as I will have a while to sit on the SUPPNet development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants