Force json file to be UTF8 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running ruby using the LANG flag set to something like C (LANG=C rake test) parsing the json file would fail in ruby 1.9. By setting the encoding on the file before parsing we avoid these issues.
|
Excellent! I've merged the patch and given you commit permission. Could you add some tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running ruby using the LANG flag set to something like C (LANG=C
rake test) parsing the json file would fail in ruby 1.9. By setting the
encoding on the file before parsing we avoid these issues.
This is possibly a bug in the json gem, but doing this gets around the issue.