Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7 part0 #621

Merged
merged 12 commits into from Mar 30, 2016
Merged

V7 part0 #621

merged 12 commits into from Mar 30, 2016

Conversation

printercu
Copy link
Member

Related to #619
@antstorm here is first part. It's also huge enough, but there are not so much real changes: mostly extracted modules, and moved files. It's a preparational part for the next commits.

Is it ok, or should I break it into smaller commits?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 99.41% when pulling a1dffe1 on printercu:v7_part0 into 6c9b727 on RubyMoney:v7.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 99.41% when pulling 7d37cb7 on printercu:v7_part0 into 6c9b727 on RubyMoney:v7.

@lunks
Copy link
Member

lunks commented Mar 30, 2016

IMHO you should move everything as the first part of the branch (no need for a PR if it's just moving) then it should be easier to review all the other changes.

@printercu printercu merged commit 7d37cb7 into RubyMoney:v7 Mar 30, 2016
@printercu printercu mentioned this pull request Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants