Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interchange order of arguments in round method #937

Closed

Conversation

tweymuth
Copy link
Contributor

This PR addresses issue #909.

@tweymuth tweymuth requested a review from antstorm July 14, 2020 15:31
@tweymuth tweymuth self-assigned this Jul 14, 2020
@tweymuth tweymuth linked an issue Jul 14, 2020 that may be closed by this pull request
@tweymuth tweymuth added this to the Version 7 milestone Jul 14, 2020
@tweymuth tweymuth added the ver:7 label Jul 14, 2020
@coveralls
Copy link

coveralls commented Jul 14, 2020

Coverage Status

Coverage remained the same at 99.815% when pulling 9c51d5b on tweymuth:reorder-round-method-arguments into 048f70b on RubyMoney:v7_new.

@antstorm
Copy link
Contributor

@tweymuth thank you for submitting the PR. What do you think would be the best way to safely roll this out?

@tweymuth
Copy link
Contributor Author

Since you mentioned in issue #909 that this change should be included for the next major release, I was silently assuming that it would be OK to have such a breaking change. I thought that we would warn the user about the breaking changes in a post-install message or something like that. (That being said, I realize I forgot to update the CHANGELOG - I'll fix that in a moment.)

In addition, we could also include a deprecation notice in one of the next minor releases, stating that the round method will work differently in version 7. If you think this is a good option, I can take care of that and prepare another PR.

@semmons99 semmons99 closed this Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round method arguments
4 participants