Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow names to have underscores #71

Closed
Tracked by #57
Rumsfield opened this issue May 21, 2023 · 1 comment · Fixed by #76
Closed
Tracked by #57

Allow names to have underscores #71

Rumsfield opened this issue May 21, 2023 · 1 comment · Fixed by #76
Assignees
@Rumsfield
Labels
enhancement New feature or request

Comments

@Rumsfield
Copy link
Owner

All user input for names are validated against common criteria. One check is for only alpha-numeric characters. Change this to allow an exception for underscores. I think it shouldn't break anything.

https://github.com/Rumsfield/konquest/blob/main/core/src/main/java/com/github/rumsfield/konquest/Konquest.java#L732
@Rumsfield Rumsfield added the enhancement New feature or request label May 21, 2023
@Rumsfield Rumsfield mentioned this issue May 21, 2023
Closed
24 tasks
@Rumsfield Rumsfield self-assigned this May 25, 2023
@Rumsfield
Copy link
Owner Author

Changing validation method to use regex:

!name.matches("([A-Za-z0-9_]+)")

@Rumsfield Rumsfield mentioned this issue May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rumsfield Rumsfield

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch/57 v0.11.1 Rumsfield/konquest
1 participant
@Rumsfield