Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locally provide crates that libgrust depends on #2882

Closed
tschwinge opened this issue Feb 27, 2024 · 1 comment · Fixed by #2943
Closed

Locally provide crates that libgrust depends on #2882

tschwinge opened this issue Feb 27, 2024 · 1 comment · Fixed by #2943
Assignees
Labels
upstream Issue regarding upstreaming gccrs into GCC

Comments

@tschwinge
Copy link
Member

As of #2822 "Start reusing rustc's format_args parser", we have:

[...]
make[3]: Entering directory '[...]/build-gcc/gcc'
cargo build --manifest-path [...]/source-gcc/gcc/../libgrust/libformat_parser/Cargo.toml --release # FIXME: Not always release, right?
    Updating crates.io index
 Downloading crates ...
  Downloaded unicode-xid v0.2.4
  Downloaded libc v0.2.152
   Compiling libc v0.2.152
   Compiling unicode-xid v0.2.4
   Compiling generic_format_parser v0.1.0 ([...]/source-gcc/libgrust/libformat_parser/generic_format_parser)
   Compiling libformat_parser v0.1.0 ([...]/source-gcc/libgrust/libformat_parser)
    Finished release [optimized] target(s) in 2.39s
[...]

For different reasons, GCC needs to build without Internet access. Therefore, need to locally provide crates that libgrust depends on, either by importing into libgrust, or by new --with-[...] configure flags and instructions how to download/prepare them externally in a suitable format (source or binary).

@tschwinge
Copy link
Member Author

I note:

$ cargo build --help
[...]
      --offline               Run without accessing the network
[...]

@CohenArthur CohenArthur added this to the GCC 14.1 release milestone Mar 1, 2024
@CohenArthur CohenArthur self-assigned this Mar 1, 2024
@CohenArthur CohenArthur added the upstream Issue regarding upstreaming gccrs into GCC label Mar 1, 2024
@tschwinge tschwinge linked a pull request Apr 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue regarding upstreaming gccrs into GCC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants