You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current InlineAsm structs have a lot of constructors where we permit the intialization of nullptr and then we would have to test to see if the pointer is nullptr before performing clone_expr (and not to mention other pointer related operation)
Please preview Arthur's review in this PR.
if expr cannot be null then it would be nice to add more assertions to this struct (but in another PR)
remove the empty constructor, as that will set expr to nullptr and thus create an invalid InOut
in the full constructor on line 4850, rust_assert(expr) to ensure that expr is not null
because expr is not null, remove the if (other.expr) checks in both the copy constructor and operator= overload
The current InlineAsm structs have a lot of constructors where we permit the intialization of nullptr and then we would have to test to see if the pointer is nullptr before performing clone_expr (and not to mention other pointer related operation)
Please preview Arthur's review in this PR.
expr
tonullptr
and thus create an invalidInOut
rust_assert(expr)
to ensure thatexpr
is not nullexpr
is not null, remove theif (other.expr)
checks in both the copy constructor andoperator=
overloadOriginally posted by @CohenArthur in #2982 (comment)
The text was updated successfully, but these errors were encountered: