Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bp384: Scalar::sqrt is unimplemented #847

Closed
2 tasks done
tarcieri opened this issue Apr 13, 2023 · 0 comments · Fixed by #918
Closed
2 tasks done

bp384: Scalar::sqrt is unimplemented #847

tarcieri opened this issue Apr 13, 2023 · 0 comments · Fixed by #918

Comments

@tarcieri
Copy link
Member

tarcieri commented Apr 13, 2023 •
edited
Loading

The following crates lack a Scalar::sqrt implementation and panic instead:

  • p224
  • bp384

Unfortunately we can't simply remove the methods because they're mandatory to implement for important traits like ff::Field
@tarcieri tarcieri changed the title p224: Scalar::sqrt is unimplemented p224/bp384: Scalar::sqrt is unimplemented Apr 16, 2023
@ashWhiteHat ashWhiteHat mentioned this issue Jul 4, 2023
Merged
@tarcieri tarcieri changed the title p224/bp384: Scalar::sqrt is unimplemented bp384: Scalar::sqrt is unimplemented Jul 8, 2023
@ashWhiteHat ashWhiteHat mentioned this issue Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bp384: impl Scalar::sqrt ashWhiteHat/elliptic-curves
1 participant
@tarcieri