Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve deprecations related to bindTo and update Action's API to match #87

Merged
merged 4 commits into from
Apr 20, 2017
Merged

Resolve deprecations related to bindTo and update Action's API to match #87

merged 4 commits into from
Apr 20, 2017

Conversation

tomburns
Copy link

Resolves #86

I'd appreciate a close eye here as I haven't touched a) this repo or 2) Carthage in a little while 🙇

ashfurrow
ashfurrow approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@freak4pc
Copy link
Member

Uhm for some reason Travis is checking out RxSwift 3.3.1
HEAD is now at 068b4de Release 3.3.1

@tomburns
Copy link
Author

Yeah, I'm assuming I missed something, but nothing is jumping out. I'll keep looking...

@tomburns tomburns closed this Apr 20, 2017
@tomburns tomburns reopened this Apr 20, 2017
@tomburns
Copy link
Author

I think I may have forgotten to push the submodule changes; restarting the build to see if that sets it straight.

@tomburns
Copy link
Author

Submodules look good on my branch, but I'm probably missing something silly: https://github.com/tomburns/Action/tree/deprecations/Carthage/Checkouts

I'll check back in on this in a bit if anyone has a sense of what's up.

@tomburns
Copy link
Author

SPM Strikes Again! Should be all set now 👍

@freak4pc
Copy link
Member

Nice! LGTM!

@freak4pc freak4pc requested review from freak4pc and removed request for freak4pc April 20, 2017 21:04
freak4pc
freak4pc approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freak4pc freak4pc merged commit 65de271 into RxSwiftCommunity:master Apr 20, 2017
@ashfurrow
Copy link
Member

Thanks a lot for contributing! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.

@freak4pc freak4pc mentioned this pull request May 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfurrow ashfurrow ashfurrow approved these changes

@freak4pc freak4pc freak4pc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warnings when using Rx >= 3.4.0
3 participants
@tomburns @freak4pc @ashfurrow