Create Rx extensions mapping to Alamofire response method #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Case:
Imagine an HTTP API which returned status code 200, with an empty body.
Using
responseJSON
orresponseData
produces:Just using RxAlamofire's
AF.rx.request(urlRequest: urlRequest).validate()
works, but if the API returns a 500, the validation doesn't actually work because the response is not yet set on theresponse
property of theDataRequest
.It seems that API's with empty bodies aren't considered bad practice, nor discouraged by the HTTP specification.
https://softwareengineering.stackexchange.com/questions/211275/should-an-http-api-always-return-a-body
The Change
Alamofire already has an API which returns just the raw
HTTPURLResponse
, this PR is just creating an Rx mapping for it.