Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RxSwift dependency to 4.1.0. #65

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Update RxSwift dependency to 4.1.0. #65

merged 1 commit into from
Apr 20, 2018

Conversation

jwutke
Copy link
Contributor

@jwutke jwutke commented Apr 20, 2018

#59 bumped the SPM RxSwift dependency to 4.1.0, but Carthage and Cocoapods were left as 4.0.0.

@freak4pc
Copy link
Member

We should really try to add some CI to this repo, I'm not sure how this went unnoticed. If the code has bind(to:) and is depending on 4.0.0 at the moment, it means the code isn't compiling without this fix?

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for one more reviewer if possible.

@devxoul
Copy link
Member

devxoul commented Apr 20, 2018

@freak4pc Hmm yeah it will probably fail if somebody uses RxSwift 4.0.0 with the latest version of RxKeyboard. I should have bumped CocoaPods and Carthage dependency in #59. Thanks for fixing it!

@devxoul devxoul merged commit 6255df1 into RxSwiftCommunity:master Apr 20, 2018
@rxswiftcommunity
Copy link

Thanks a lot for contributing @jwutke! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants