Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX version ? #4

Closed
plm75 opened this issue Jul 21, 2016 · 17 comments
Closed

OSX version ? #4

plm75 opened this issue Jul 21, 2016 · 17 comments

Comments

@plm75
Copy link

plm75 commented Jul 21, 2016

Would be great to have it as a desktop app too

@yury
Copy link
Contributor

yury commented Jul 22, 2016

I think, playgrounds are better choice on desktop.

@yury yury closed this as completed Oct 7, 2016
@yury yury reopened this Jan 9, 2020
@freak4pc
Copy link
Member

freak4pc commented Jan 9, 2020

Catalyst time? :]

@yury
Copy link
Contributor

yury commented Jan 9, 2020

Yep :)

@freak4pc
Copy link
Member

freak4pc commented Jan 9, 2020

Need help with that or you'll take over it?

@yury
Copy link
Contributor

yury commented Jan 9, 2020

I will try to do that on weekend, but any PR is welcomed!

@freak4pc
Copy link
Member

Have to say it looks quite good with very few changes. Need to fix up the onboarding and some of the dark mode things. Maybe better to merge #21 first?

image

@yury
Copy link
Contributor

yury commented Jan 10, 2020

Wow!

yep, we should merge #21, but we need to revert RxMarbles.xcodeproj/project.pbxproj changes. Actually current version in App Store also has broken dark theme :(

@freak4pc
Copy link
Member

Yup, probably because it was built in Xcode 11 (iOS 13 SDK)

@freak4pc
Copy link
Member

😍

image

@yury
Copy link
Contributor

yury commented Jan 10, 2020

Awesome!

@yury
Copy link
Contributor

yury commented Jan 14, 2020

@freak4pc is somewhere public branch, so I can pickup and help you?

@freak4pc
Copy link
Member

@yury I don't think I pushed the changes, if you want to help with reviewing #22, I'll wrap up my changes and push them onto a branch for you. WDYT ?

@yury
Copy link
Contributor

yury commented Jan 14, 2020

@freak4pc done

@freak4pc
Copy link
Member

freak4pc commented Jan 14, 2020 via email

@zeeshankhan
Copy link

Hey guys,
Any plan to push the app on the App Store and catalyst on the Mac App Store?

@freak4pc
Copy link
Member

Hey, super sorry about this. I totally forgot I never pushed the branch up 🤦
I plan to take care of this a bit later today or tomorrow (just put this on my todo list).

Cheers.

@freak4pc
Copy link
Member

I actually forgot about not forgetting, the PR is there for a while.
Let's continue the discussion over there #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants