am/gui: Implement Wake-up message #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AcK77
added
enhancement
riperiperi
reviewed
Nov 26, 2020
| EnqueueMessage(MessageInfo.FocusStateChanged); | ||
| } | ||
|
|
||
| public void EnqueueMessage(MessageInfo message) |
There was a problem hiding this comment.
Why have these been moved out of this class? Surely signalling the event after each enqueue is desirable, and easier to do if you only have to use one line to do it.
There was a problem hiding this comment.
Because AM service signal the event if messages left in the buffer (checked by RE).
We currently do that outside of the AM service which is wrong. That’s why I’ve moved the logic in the service call and remove unused methods.
marysaka
approved these changes
Dec 3, 2020
gdkchan
reviewed
Dec 10, 2020
...S/Services/Am/AppletAE/AllSystemAppletProxiesService/SystemAppletProxy/ICommonStateGetter.cs
Outdated
Show resolved
Hide resolved
This implement the ability to send a Wake-up (Resume) message to the guest. Sometime games needs to Sleep and Wake-up the switch to unlock some ingame features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement the ability to send a Wake-up (Resume) message to the guest.
Some games needs to sleep and wake-up the switch to unlock some ingame features, we now supports that.
I've cleaned up the
AppletStateclass andICommonStateGetter::ReceiveMessagecall is implemented accordingly to RE.(Thanks to Ryushu on Discord for helping me to reproduce the issue)