Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: add Show Confirm Exit toggle #1856

Merged
merged 1 commit into from
Jan 14, 2021
Merged

settings: add Show Confirm Exit toggle #1856

merged 1 commit into from
Jan 14, 2021

Conversation

macabeus
Copy link
Contributor

@macabeus macabeus commented Jan 2, 2021 •
edited
Loading

Closes #1853

image

macabeus
macabeus commented Jan 2, 2021
View reviewed changes
Ryujinx/Ui/MainWindow.cs
{
End(_emulationContext);
}
}

private void Window_Close(object sender, DeleteEventArgs args)
{
if (!_gameLoaded || GtkDialog.CreateExitDialog())
if (!_gameLoaded || !ConfigurationState.Instance.ShowConfirmExit || GtkDialog.CreateExitDialog())
Copy link
Contributor Author

@macabeus macabeus Jan 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that I'm calling !ConfigurationState.Instance.ShowConfirmExit every time that is called GtkDialog.CreateExitDialog.... and it looks a little ugly for me.
Maybe we could do it better?

@EmulationFanatic EmulationFanatic changed the title settings: add Show Confirm Exist toggle settings: add Show Confirm Exit toggle Jan 2, 2021
@EmulationFanatic
Copy link
Contributor

The "Check for" text doesn't make sense here. The option should just be 'Show "Confirm Exit" Dialog'

@EmulationFanatic EmulationFanatic added enhancement New feature or request gui Related to Ryujinx.Ui labels Jan 2, 2021
@SeraUQ
Copy link
Contributor

SeraUQ commented Jan 2, 2021

Would also be good to add the appropriate stuff to /Ryujinx/Config.json and /Ryujinx/_schema.json

@macabeus
Copy link
Contributor Author

macabeus commented Jan 2, 2021

@EmulationFanatic @SeraUQ @AcK77 Done.

@macabeus macabeus mentioned this pull request Jan 4, 2021
Closed
@macabeus macabeus requested a review from AcK77 January 5, 2021 12:54
marysaka
marysaka approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@marysaka marysaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AcK77
Copy link
Member

AcK77 commented Jan 8, 2021 •
edited
Loading

Needs a rebase

@macabeus
Copy link
Contributor Author

macabeus commented Jan 9, 2021

@AcK77 Done

AcK77
AcK77 approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@AcK77 AcK77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@AcK77 AcK77 requested review from gdkchan and Xpl0itR January 11, 2021 15:05
Xpl0itR
Xpl0itR approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@Xpl0itR Xpl0itR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@marysaka marysaka merged commit 1e5b37c into Ryujinx:master Jan 14, 2021
@macabeus macabeus deleted the solve-1853 branch January 14, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marysaka marysaka marysaka approved these changes

@AcK77 AcK77 AcK77 approved these changes

@Xpl0itR Xpl0itR Xpl0itR approved these changes

@gdkchan gdkchan Awaiting requested review from gdkchan

Assignees
No one assigned
Labels
enhancement New feature or request gui Related to Ryujinx.Ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Setting to Toggle Disabling the Pop-Up that Prompts the User to Confirm Exit
6 participants
@macabeus @EmulationFanatic @SeraUQ @AcK77 @marysaka @Xpl0itR