Initial Setup: Reload keys before verifying firmware #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, display the NoKeys dialog if keyset is empty when verifying firmware.
AcK77
approved these changes
Jan 24, 2021
AcK77
added
fix
marysaka
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the initial setup UX. After placing keys, the user no longer needs to restart Ryujinx before installing firmware. Also, if they disregard the
NoKeysdialog, it'll be shown again when a firmware is selected.Closes #1843
Slightly unrelated, I noticed the generic exception log in
LoadApplications()is cryptic unless debug logs are enabled but a dialog pops up asking to check logs. So, moved the exception to the warning itself.