Account for pool change on texture bindings cache #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marysaka
approved these changes
Jun 25, 2022
AcK77
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3399 tries to avoid texture binding updates if the state does not change, however it has one flaw, it checks if the texture and sampler IDs changed, and checks if the pool contents changed, but it does not check if the pool itself changed. This causes issues for games that changes the pools but keeps the same bindings. This seems pretty rare so I believe the number of games affected by the regression is low.
Fixes regression on Super Zangyura.
Before:
After:
Closes #3419.