Allow Surface Flinger frame enqueue after process has exited #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdkchan
added
fix
marysaka
approved these changes
Oct 2, 2022
AcK77
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because surface flinger is disposed after the guest processes, it is possible it will try to enqueue a pending frame when the process has already exited. This will cause an exception to be thrown on tne
EnqueueFrameThreadSafemethod. This change makes it not throw and instead return a bool indicatiing if the frame was added to the queue or not. Surface Flinger can then deal with this and release the frame immediately.This fixes an exception that could be thrown in some rare cases while ending emulation.