Change NvMap ID allocation to match nvservices #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdkchan
added
fix
marysaka
approved these changes
Oct 5, 2022
AcK77
approved these changes
Oct 5, 2022
|
Seems to also resolve the random crashes exhibited in Breath of the Wild. |
|
Fixes the following things in Animal Crossing New Horizons:
TLDR: This fixes afaik every single bug left in the game. This is just amazing <3 |
|
After playing 40 mind-numbing minutes of Pokémon Sword and going through pokecenter doors for 5 of them, it's possible this might have fixed random crashes in Sword/Shield as well. Here's a Sword save in case anyone is willing to test further. |
|
I can confirm that all of these are now fixed for me too. Excellent sleuthing! |
riperiperi
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the NvMap ID allocation to match what the official service does. The official service uses an ever incrementing ID (which seems very odd to me, since it eventually can overflow, but it would probably take long enough to happen that no one will experience it in practice unless they leave a game running for months/years and it constantly create nvmaps). It also increments the ID by 4 rather than 1 which is also weird (and would make it overflow even faster...)
This fixes a random crash that could happen when starting a new game on Animal Crossing: New Horizons. A similar issue on other titles might be also fixed.
Testing is welcome.