UI: Expose games build ID for cheat management

[gnisman]

Currently Ryujinx is not exposing Build ID to the user in the UI which make it hard to manage cheats

Closes #3397

[github-actions]

Download the artifacts for this pull request:

• ryujinx-Release-1.1.0+9ef0fec-linux_x64
• ryujinx-Release-1.1.0+9ef0fec-osx_x64
• ryujinx-Release-1.1.0+9ef0fec-win_x64

Experimental GUI (Avalonia)

• ava-ryujinx-Release-1.1.0+9ef0fec-linux_x64
• ava-ryujinx-Release-1.1.0+9ef0fec-osx_x64
• ava-ryujinx-Release-1.1.0+9ef0fec-win_x64

GUI-less (SDL2)

• sdl2-ryujinx-headless-Release-1.1.0+9ef0fec-linux_x64
• sdl2-ryujinx-headless-Release-1.1.0+9ef0fec-osx_x64
• sdl2-ryujinx-headless-Release-1.1.0+9ef0fec-win_x64

Only for Developers

• ava-ryujinx-Debug-1.1.0+9ef0fec-linux_x64
• ava-ryujinx-Debug-1.1.0+9ef0fec-osx_x64
• ava-ryujinx-Debug-1.1.0+9ef0fec-win_x64
• ryujinx-Debug-1.1.0+9ef0fec-linux_x64
• ryujinx-Debug-1.1.0+9ef0fec-osx_x64
• ryujinx-Debug-1.1.0+9ef0fec-win_x64
• sdl2-ryujinx-headless-Debug-1.1.0+9ef0fec-linux_x64
• sdl2-ryujinx-headless-Debug-1.1.0+9ef0fec-osx_x64
• sdl2-ryujinx-headless-Debug-1.1.0+9ef0fec-win_x64

[MetrosexualGarbodor]

I can't test right now, does this change whenever a game update is added or removed?

[gnisman]

I can't test right now, does this change whenever a game update is added or removed?

Yes

[gdkchan]

The way how the build ID is currently formatted (inside brackets after the game name) is the as the title ID, which can lead someone to assume this is the title ID rather than build ID. Maybe it would be better to have something explicitly say that this is the build ID.

[gnisman]

The way how the build ID is currently formatted (inside brackets after the game name) is the as the title ID, which can lead someone to assume this is the title ID rather than build ID. Maybe it would be better to have something explicitly say that this is the build ID.

Wanted to change it to something like "Cheats Available for {0} [Build id: {1}]"
But CheatWindowHeading exists in 14 different languages in AVA, do we really want to change it?
In my opinion title id and build id looks completely different to mistake between them
but on the other hand users got used to see title id in this cheats window.
What do you suggest to do?

[OldManKain]

Don't mind my crappy editiing skills but would it be possible to add the BID's something like this?

[gnisman]

Don't mind my crappy editiing skills but would it be possible to add the BID's something like this?

It is possible but i dont think there is much use for the Tittle Id here, just adds bloat

[gnisman]

@gdkchan , @OldManKain added BID as a prefix (updated the original screenshots) what do you think?

[jojodunet]

Personally, I think it’s better to see the both, TID and BID, on the same window.
Something like shown by @OldManKain

[AcK77]

IMO the BuildId should be extracted (and cached in the game json maybe?) when games are loaded in the gamelist, the method should be in Ryujinx.Ui.Common instead of ApplicationLoader and the BuildId should be shown in a readonly textbox to be able to copy/paste it.

[gnisman]

IMO the BuildId should be extracted (and cached in the game json maybe?) when games are loaded in the gamelist, the method should be in Ryujinx.Ui.Common instead of ApplicationLoader and the BuildId should be shown in a readonly textbox to be able to copy/paste it.

Moved the method to Ryujinx.Ui.Common and Build id is shown as readonly Text Box now

about extracting build id when games are loaded in the game list, not sure it will be a good to extract build id of all the games ahead of time but rather only when needed in cheat window.
maybe we should address it as part of #3285

[gnisman]

@AcK77 , @OldManKain do you think that the bid as a text box looks visually ok? (screenshots updated at the first comment)

[OldManKain]

@AcK77 , @OldManKain do you think that the bid as a text box looks visually ok? (screenshots updated at the first comment)

I can live with that, now it's up to the higher ups to make their decision.

[TSRBerry]

Lgtm, thank you for being so patient with me!

[gnisman]

Lgtm, thank you for being so patient with me!

Thanks for the review and the suggestions, appreciate it

[TSRBerry]

Your latest commit is not correct unfortunately. Could you please drop this one and rebase your PR instead?

[gnisman]

Your latest commit is not correct unfortunately. Could you please drop this one and rebase your PR instead?

Hey,
can you explain what is wrong with the merge? or you just prefer rebases instead of merges?

[TSRBerry]

Oh sorry, it seems like it was correct after all and I just didn't read it properly. I thought you added your changes outside of the src directory.

[AcK77]

Some last things and it should be good ;)! Thanks!

[gnisman]

Some last things and it should be good ;)! Thanks!

Done, Thanks for the feedback