Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syscall capabilites to include SVCs from FW 15.0.0 #4530

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

TSRBerry
Copy link
Member

@TSRBerry TSRBerry commented Mar 10, 2023

This PR introduces a new KernelConstant SupervisorCallCount which gets used to make sure we are not setting SVCs that are out of range.

Since the amount of SVCs increased with firmware version 15.0.0, I also increased the size of SvcAccessMask to make room for them.

Additionally an enum (CapabilityType) was introduced along with some common operations in CapabilityExtensions to make the code a little bit more readable.

As a result of this PR the homebrew menu (using hbl.nsp) can now be launched again!


I'm planning on adding the logic for MapRegion capabilities, which is why this PR is currently marked as a draft.
Nvm, it seems MapRegion is mostly unused and is probably not worth the effort required to support it for now.
If you still want me to add it before accepting this PR feel free to tell me.

@TSRBerry TSRBerry added the kernel Related to the kernel label Mar 10, 2023
@TSRBerry TSRBerry marked this pull request as ready for review March 10, 2023 21:00
Copy link
Member

@gdkchan gdkchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

Ryujinx.HLE/HOS/ProgramLoader.cs Outdated Show resolved Hide resolved
@TSRBerry TSRBerry linked an issue Mar 14, 2023 that may be closed by this pull request
@TSRBerry TSRBerry merged commit 7870423 into Ryujinx:master Mar 17, 2023
@TSRBerry TSRBerry deleted the update-caps branch March 17, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Related to the kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hbl.nsp v2.4.3 and nx_hbloader.nro v3.5.1 [Bug]
3 participants