Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default queue sizes are most probably too large #3

Open
S-S-X opened this issue Mar 15, 2021 · 0 comments
Open

Default queue sizes are most probably too large #3

S-S-X opened this issue Mar 15, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@S-S-X
Copy link
Owner

S-S-X commented Mar 15, 2021

Queues should not get filled very often, most probably if queue gets full then there's some other problems that should be solved.

Most common reason for queues getting filled will be requests timing out with long timeouts. This is something that can be somewhat handled with QoS.

Other reasons can include mods that do something really stupid like sending request from global dig handler etc. and these reasons are not something that should be fixed with QoS.

It would probably be better to have bit smaller queues, for example if parallel requests is set to 16 then with current defaults:

  • priority 1 queue size is 256 requests + 64 requests in engine queue
  • priority 2 queue size is 192
  • priority 3 queue size is 128

Assuming worst case scenario with 640 requests queued or reading reply and probable cause which is timeouts.
Default request timeout is 3 seconds, if all requests are going to time out processing whole queue takes at least 156 seconds to complete (taking processing order and priority limits into account).
Such situation can be very likely if some network service that is called frequently goes down and stays down for some time.
Very related: #2

@S-S-X S-S-X added the enhancement New feature or request label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant