Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

[Migration Tools] Research and implement a way to store integration tests passwords securely #275

Closed
vmutafov opened this issue Jun 29, 2021 · 2 comments

Comments

@vmutafov
Copy link
Contributor

For the migration tools E2E integration tests we need a way to store the Neo and HANA test users' passwords and emails. We should check if the other XSK modules have such scenarios and how they deal with them. If this problem exists in other modules as well, we should use some key vault to store the passwords without the need to hardcode them in the code.

@ThuF
Copy link
Contributor

ThuF commented Aug 11, 2021

Shouldn't these credentials be provided via environment variables? There shouldn't be any hardcoded values in the integration tests.

@ThuF
Copy link
Contributor

ThuF commented Aug 11, 2021

Environment variables will be used and for CI/CD purposes the credentials will be provided via GitHub Actions Credentials.

@ThuF ThuF closed this as completed Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants