Make test for unique stacks more robust #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
RealCLanger
reviewed
Sep 5, 2024
| OutputAnalyzer oa = callJcmd(p, "MallocTrace.dump", "-percentage=100"); | ||
| // The output can be large, so dump it directly, since the output of | ||
| // jcmd is temporary hold in the JVM and there is a limit of 100 MB. | ||
| final String[] stacks = new String[1]; |
There was a problem hiding this comment.
Any reason why you are using a String[] here instead of a single String object?
There was a problem hiding this comment.
You cannot modify a local variable in an anonymous inner class. So the array trick is the common way.
RealCLanger
approved these changes
Sep 9, 2024
If this really fixes the problem in the tests. |
It should - it looks greenish now. And the error happened on all our ppc64le nodes before. |
MBaesken
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way the stack traces are routed to the test the uniques stacks test, since it produces a big output. We now let the profiled VM print the stacks to stderr and not use the output of jcmd, since the latter is buffered in the profiled VM first and there are hard limits on the maximum size of that buffer,.
fixes #1810