feat: 🎸 Action button enhancement for different size class #27
Conversation
ShadowTourist
force-pushed
the
action-button-enhancment
branch
from
f8483c9
to
aa87252
Compare
|
Thanks for the PR. A minor suggestion for commit message:
|
There was a problem hiding this comment.
@ShadowTourist please add/enhance SwiftUI preview implementation to allow quick tests for portrait and landscape mode. Example
Also, it is helpful to drop screenshots into PR description/comment illustrating the before and after effect
| Before | After |
|---|---|
 |
 |
I see the improvement in landscape mode for "List icon v..." button :)
But as you maybe can see the side effect is that "Footer button" label size also decreased which looks funky as the "View More" label size is different
|
@justinguo Got it, I will update commit message later and I did't change size for Demo 8 which is a @MarcoEidinger |
|
@ShadowTourist Agree. There are places for improvements and we might discuss how to refactor them at a later point. Currently we hope to close the UI gaps between design and actual SDK ASAP, then we need to finish the research topics, at the end if have time we can pick some areas to improve. Please address what Marco suggested first. We can have a quick sync-up tonight. |
ShadowTourist
force-pushed
the
action-button-enhancment
branch
from
aa87252
to
d2929ee
Compare
ShadowTourist
changed the title
ShadowTourist
force-pushed
the
action-button-enhancment
branch
5 times, most recently
from
efa8b20
to
27491aa
Compare
|
Hi @MarcoEidinger I have attached the screenshot and preview.
|
ShadowTourist
force-pushed
the
action-button-enhancment
branch
3 times, most recently
from
0199890
to
478ced4
Compare
| @@ -18,20 +23,26 @@ struct QuickRepliesMessageView: View { | |||
| assertionFailure("only use `QuickRepliesMessageView` with message type `quickReplies`") | |||
| return nil | |||
| } | |||
|
|
|||
| var amountOfButtons: Int { | |||
| let limitForVisibleButtons = 11 | |||
There was a problem hiding this comment.
So in this case we are limiting number of quick reply buttons to 11?
There was a problem hiding this comment.
@justinguo yes, I introduced this in a different commit to align behavior with WebClient
There was a problem hiding this comment.
@MarcoEidinger Got it! So the solution looks good to me.
|
Please also address the conflict. |
|
@ShadowTourist I pushed a new commit to dev branch to ensure that header in files get striped when running P.S.: I strongly recommend to rebase (instead of merge) when pulling latest changes from dev branch into your local feature branch. This will avoid that other commits (not from you) are listed in your PR. If you have any questions about this I can explain how to do that in our next sync meeting |
ShadowTourist
force-pushed
the
action-button-enhancment
branch
from
1ef3de7
to
478ced4
Compare
|
@MarcoEidinger I prefer rebase too. I'm not familiar with fork work flow yet. I will check commits again. |
Action button's max width is increased to 200 for landscape.
ShadowTourist
force-pushed
the
action-button-enhancment
branch
from
478ced4
to
49d36b9
Compare
|
Hi @MarcoEidinger I dropped the merge commit and rebase the latest dev. |
* feat: 🎸 Action button enhancement for different size class Action button's max width is increased to 200 for landscape. * style: 💄 fix swift format * style: 💄 format fix
Action button's max width is increased to 200 for landscape.