Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eslint use isnan #204

Merged
merged 2 commits into from
Jan 15, 2019
Merged

fix: eslint use isnan #204

merged 2 commits into from
Jan 15, 2019

Conversation

greg-a-smith
Copy link
Contributor

@greg-a-smith greg-a-smith commented Jan 15, 2019 •
edited by bcullman
Loading

Enabled the use-isnan eslint rule and fixed lint errors.

#169

@greg-a-smith greg-a-smith requested a review from a team January 15, 2019 04:20
bcullman
bcullman approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@bcullman bcullman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

there seems to be some duplication in logic here which could be refactored at a later time.

separately, there is a y3k issue here.

🚢

@greg-a-smith greg-a-smith merged commit 5878b5b into master Jan 15, 2019
@greg-a-smith greg-a-smith deleted the fix/eslint-use-isnan branch January 15, 2019 05:46
greg-a-smith added a commit that referenced this pull request Mar 5, 2019
@greg-a-smith
fix: eslint use isnan (#204)
cc63a04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcullman bcullman bcullman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg-a-smith @bcullman