fix: update doc, add pagination spread props #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-a-smith
suggested changes
Jan 17, 2019
| 'object - additional props to be spread to the display total section' | ||
| }, | ||
| { | ||
| name: 'linkProps', |
There was a problem hiding this comment.
I missed the original PR (#224), but should we have two separate props for the "previous" and "next" links?
There was a problem hiding this comment.
Separate props as in a prevNextProps which is different than the linkProps or as in prevProps and nextProps
There was a problem hiding this comment.
I was asking about prevProps and nextProps.
There was a problem hiding this comment.
ok, i just added a prevProps and nextProps values to the pagination control
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: update doc, add pagination spread props * added prevProps and nextProps properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include displayTotalProps and linkProps in the documentation for Pagination component