Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dialog resize handle alignment [ci visual] #2832

Merged
merged 1 commit into from Oct 27, 2021
Merged

fix: dialog resize handle alignment [ci visual] #2832

merged 1 commit into from Oct 27, 2021

Conversation

dmitry-stepanenko
Copy link
Contributor

Related Issue

Closes SAP/fundamental-ngx#6332

Description

Fixed alignment of the resize handle

This is a second PR, some comments were left on #2774

Screenshots

Before:

image

After:

image

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • [n/a] All values are in rem
  • Text elements follow the truncation rules
  • hover state of the element follow design spec
  • focus state of the element follow design spec
  • active state of the element follow design spec
  • selected state of the element follow design spec
  • selected hover state of the element follow design spec
  • pressed state of the element follow design spec
  • Responsiveness rules - the component has modifier classes for all breakpoints
  • Includes Compact/Cosy/Tablet design
  • RTL support
  1. The code follows fundamental-styles code standards and style
  • only one top level fd-* class is used in the file
  • BEM naming convention is used
  • Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.)
  • A11y support - keyboard support, screenreader support, proper ARIA attributes, etc.
  • fd-reset() mixin is applied to all elements
  • Variables are used, if some value is used more than twice.
  • Checked if current components can be reused, instead of having new code.
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Verified all styles in IE11
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Storybook documentation has been created/updated
  • Breaking Changes wiki has been updated in case of breaking changes.

@dmitry-stepanenko dmitry-stepanenko mentioned this pull request Oct 16, 2021
Closed
24 tasks
@netlify
Copy link

netlify bot commented Oct 16, 2021 •
edited

✔️ Deploy Preview for fundamental-styles ready!

🔨 Explore the source changes: f06faa6

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/61704213d82fac0007ddaf8d

😎 Browse the preview: https://deploy-preview-2832--fundamental-styles.netlify.app

InnaAtanasova
InnaAtanasova requested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the deployed preview the resize handle is still off. This is what I see
Screen Shot 2021-10-18 at 11 51 12 AM
:
Screen Shot 2021-10-18 at 11 50 36 AM

@nickiovenko nickiovenko added this to the Sprint 73 - Ariba milestone Oct 19, 2021
@dmitry-stepanenko
Copy link
Contributor Author

dmitry-stepanenko commented Oct 20, 2021 •
edited

@InnaAtanasova adjusted it.

@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Oct 25, 2021
@droshev droshev removed the stale label Oct 26, 2021
@droshev droshev merged commit d601993 into main Oct 27, 2021
@droshev droshev deleted the ds/6332-resize-handle-alignment branch October 27, 2021 00:15
InnaAtanasova pushed a commit that referenced this pull request Oct 29, 2021
@dmitry-stepanenko @InnaAtanasova
fix(styles): dialog resize handle alignment [ci visual] (#2832)
b027432
droshev added a commit that referenced this pull request Oct 30, 2021
@InnaAtanasova @dependabot
@fundamental-bot @N1XUS @dmitry-stepanenko @droshev
feat(styles): add horizon delta for Checkbox and Radio (#2868)
e366aec 
BREAKING CHANGE:
checkbox and radio button markup changes

* chore(deps-dev): bump standard-version from 9.3.1 to 9.3.2 (#2850)

Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 9.3.1 to 9.3.2.
- [Release notes](https://github.com/conventional-changelog/standard-version/releases)
- [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md)
- [Commits](conventional-changelog/standard-version@v9.3.1...v9.3.2)

---
updated-dependencies:
- dependency-name: standard-version
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(release): version 0.20.1-rc.54 build 1157 [ci skip]

* chore(deps-dev): bump clean-css-cli from 5.4.1 to 5.4.2 (#2849)

Bumps [clean-css-cli](https://github.com/clean-css/clean-css-cli) from 5.4.1 to 5.4.2.
- [Release notes](https://github.com/clean-css/clean-css-cli/releases)
- [Changelog](https://github.com/clean-css/clean-css-cli/blob/master/History.md)
- [Commits](clean-css/clean-css-cli@v5.4.1...v5.4.2)

---
updated-dependencies:
- dependency-name: clean-css-cli
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(release): version 0.20.1-rc.55 build 1158 [ci skip]

* chore(deps-dev): bump tocbot from 4.13.4 to 4.13.5 (#2845)

Bumps [tocbot](https://github.com/tscanlin/tocbot) from 4.13.4 to 4.13.5.
- [Release notes](https://github.com/tscanlin/tocbot/releases)
- [Changelog](https://github.com/tscanlin/tocbot/blob/master/CHANGELOG.md)
- [Commits](tscanlin/tocbot@v4.13.4...v4.13.5)

---
updated-dependencies:
- dependency-name: tocbot
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(release): version 0.20.1-rc.56 build 1159 [ci skip]

* chore(deps-dev): bump postcss from 8.3.9 to 8.3.11 (#2847)

Bumps [postcss](https://github.com/postcss/postcss) from 8.3.9 to 8.3.11.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.3.9...8.3.11)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(release): version 0.20.1-rc.57 build 1162 [ci skip]

* chore(deps-dev): bump husky from 7.0.2 to 7.0.4 (#2848)

Bumps [husky](https://github.com/typicode/husky) from 7.0.2 to 7.0.4.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v7.0.2...v7.0.4)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(release): version 0.20.1-rc.58 build 1163 [ci skip]

* chore(deps-dev): bump babel-loader from 8.2.2 to 8.2.3 (#2846)

Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.2.2 to 8.2.3.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.2.2...v8.2.3)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(release): version 0.20.1-rc.59 build 1164 [ci skip]

* chore(deps-dev): bump babel-jest from 27.2.5 to 27.3.1 (#2851)

Bumps [babel-jest](https://github.com/facebook/jest/tree/HEAD/packages/babel-jest) from 27.2.5 to 27.3.1.
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v27.3.1/packages/babel-jest)

---
updated-dependencies:
- dependency-name: babel-jest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(release): version 0.20.1-rc.60 build 1170 [ci skip]

* fix(styles): add focus state for activable row and cell [ci visual] (#2841)

* fix(styles): add focus state for activable row and cell [ci visual]

* fix(styles): address pr comments [ci visual]

* chore(release): version 0.20.1-rc.61 build 1195 [ci skip]

* fix(styles): dialog resize handle alignment [ci visual] (#2832)

* chore(release): version 0.20.1-rc.62 build 1204 [ci skip]

* feat(styles): add horizon delta for Checkbox and radio

* feat(styles): update package and package-lock

* chore(styles): revert CHANGELOG.md changes

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: fundamental-bot <fundamental@sap.com>
Co-authored-by: N1XUS <denis.severin@valor-software.com>
Co-authored-by: Dmitriy Stepanenko <33101123+dmitry-stepanenko@users.noreply.github.com>
Co-authored-by: droshev <mladen.droshev@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 74 - Ariba
Development

Successfully merging this pull request may close these issues.

bug: Dialog(core): Resize icon is crookedly located
4 participants
@dmitry-stepanenko @InnaAtanasova @droshev @nickiovenko