Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPENDENCY] Upgrade to UI5 Tooling Version 3 #536

Merged
merged 1 commit into from
Feb 9, 2023
Merged

[DEPENDENCY] Upgrade to UI5 Tooling Version 3 #536

merged 1 commit into from
Feb 9, 2023
+87 −78

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Feb 9, 2023 •
edited
Loading

Upgrade UI5 Tooling dependencies to V3

@flovogt flovogt requested a review from matz3 February 9, 2023 14:57
@coveralls
Copy link

Coverage Status

Coverage: 55.634%. Remained the same when pulling ec9179b on update-tooling-v3 into 4fb5bf7 on main.

matz3
matz3 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite the message to use [DEPENDENCY] to mention the dependency upgrade.
This is not a breaking change, and we already have an entry with [FEATURE] for the support of v3.

@flovogt flovogt merged commit 8b294d8 into main Feb 9, 2023
@flovogt flovogt deleted the update-tooling-v3 branch February 9, 2023 16:45
@flovogt flovogt changed the title [BREAKING] Upgrade to UI5 Tooling Version 3 [DEPENDENCY] Upgrade to UI5 Tooling Version 3 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flovogt @coveralls @matz3