-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide additional logging capabilities #161
Conversation
push assertion result to karma
test |
There are currently problems with the Travis CI infrastructure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a new integration test scenario.
You can copy one of the folders in test/integration/
and adopt it to use the new configuration property.
Also the result should be asserted in some way (e.g. via the log in the assertions
function of the karma.conf.js
file).
Hi @matz3 , |
@EdStrickland the idea of the integration tests is to verify the plugin e2e by e.g. checking whether karma was successful and e.g. expecting some console output. In this case I think you could have some dummy tests with dummy assertions and then check for the log output to contain the expected number of successful tests reported by karma. |
merge master
merge master
Hi @matz3 , I just tried to run the integration tests today but most of them seems to be failing. any ideas? Async callback was not invoked within the 10000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 10000ms timeout specified by jest.setTimeout.Error |
For me it's working. Maybe it just takes some more time on your machine. Have you tried increasing the timeout to see whether it finishes at some time? |
test/integration/application-log-assersion/karma-reporter/index.js
Outdated
Show resolved
Hide resolved
test/integration/application-log-assersion/webapp/test/test.qunit.js
Outdated
Show resolved
Hide resolved
Hi @matz3 , |
Can someone take a look at the new changes please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that it took me so long to do a full review
test/integration/application-log-assersion/karma-reporter/index.js
Outdated
Show resolved
Hide resolved
test/integration/application-log-assersion/webapp/test/GherkinTestRunner.html
Outdated
Show resolved
Hide resolved
test/integration/application-log-assersion/webapp/test/Website.html
Outdated
Show resolved
Hide resolved
…TestRunner.html Co-authored-by: Matthias Oßwald <1410947+matz3@users.noreply.github.com>
….html Co-authored-by: Matthias Oßwald <1410947+matz3@users.noreply.github.com>
Co-authored-by: Matthias Oßwald <1410947+matz3@users.noreply.github.com>
1) add new config logHTMLFilePath 2) add new case for the config
Hi @matz3 , how's it going? Anything update on the review? |
I'm sorry. No progress, yet. |
Hi @EdStrickland, hope you're doing ok. After absences we're gonna catch-up with your PR and keep you updated. |
Thanks @ecker, were you on vacation? Hope you had a great time. |
@EdStrickland I had a deep look into cucumber as I was still unsure about the current state of the report and I would really like to fully understand this requirement / scenario. Unfortunately the report didn't look as I would expect it to be (using both new options) Here is a report of the same Filter.feature file, based on cucumber-js (Node.js), which looks like the expected state Feature: Filtering
Lorem ipsum
Background:
Given I have started the app
And I can see 2 items in the list
Scenario: Filtering for 'Active' items
When I filter for active items
Then I can see 1 item in the list
Scenario: Filtering for 'Completed' items
When I filter for completed items
Then I can see 1 item in the list
Could you please have a look into this? Is that what you would also expect? |
Hi @matz3 , sorry I was on a vacation. It's been a while so I will need some time to rerun my manual tests to verify. |
Hi @matz3 , sorry for the delay. It's months ago since I last replied. Our team was reviewing the possibility of using WDIO instead of OPA. Luckily, OPA stays. Anyway, I cloned your code and run myself, found a bug and fixed it. and now the logs is displayed as expected in your demo. Also, I noticed that we are using SauceLabs to run the tests but it seems to keep failing, would you kindly take a look? |
Where did you fix the bug? I can't find any related change in the 3 new commits. It's just a merge and fixing eslint issues. Or did I miss something? Do you mean the |
You can ignore the |
Fine. Please verify the test results from your side, see if we can merge this PR. |
Please see my previous comment. I don't think this is ready to be merged. |
Sorry I overlooked the previous comment. I checked my code, and it seems that my latest commit was failed to be pushed. Just pushed the change, please verify. |
This config was created because karma-ui5 logs the file path in test result. However, the karma-cucumber-reporter would mistake the file path as the feature description and the output cucumber.json would be messy. |
Hey @EdStrickland! I'm deeply sorry that there hasn't been any further activities from our side. At some point the work on this contribution has ended, but no communication has been made, as the hope was that it will be continued at some point. As this unfortunately never happened and the Karma project itself has been deprecated, we will not work on new features, but continue to maintain our plugin until there's an official successor for UI5 testing announced. |
push assertion result to karma