Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Introduce ability to save Favorites in Blogs and Tutorials tabs #86

Open
4 tasks
cjbernal opened this issue May 8, 2023 · 4 comments
Open
4 tasks
Assignees

Comments

@cjbernal
Copy link
Member

cjbernal commented May 8, 2023

As a Knowledge Hub user,
I want to save blogs and tutorials that are interesting to me,
so that I read/use them later without having to search again

Description

Users may have articles or blogs they have discovered via Knowledge Hub that they wish to return to later -- either because they use the contents frequently or they didn't have time to start/finish the content. We can simplify their experience of finding the materials again by allowing users to save them as a "Favorite".

Technical Design

What modules need to be created or enhanced?
How would the functionality be exposed and how can it be consumed?

Acceptance Criteria

GivenWhenThen format (https://martinfowler.com/bliki/GivenWhenThen.html)

Given I have the blogs/tutorials tab open with content displayed
when I click the Favorites icon next to a blog/tutorial
then that piece of content will be saved in a favorites list to be referred to later.

Given I have previously saved contents for my Favorites list
when I click on the button/tab to open the Favorites list
then a list of content that I have previously marked as a Favorite will be displayed.

Given I have the Favorites list open
when I click on content that has been saved in the Favorites list
then the content will open in the browser.

Notes

Tasks

  • Locally store blog post and tutorial IDs (extension storage)
  • Get data from stored IDs and display in Favorites tab/section
  • Unit Tests added
  • Test Cases defined
@aakankshagupta1994 aakankshagupta1994 self-assigned this May 9, 2023
@gpeuc
Copy link

gpeuc commented May 11, 2023

Alright, we have some general idea how this would work (little stars at various objects, and then we expose this later somewhere), but can we first get some tech confirmation that this would work?

We most likely need some local storage, where IDs are stored. Blog post ID, and Tutorial ID, and later we read them in the Favourites section, or something like that. But can we first get some confirmation that this works, and then we will go into UI of it?

@cjbernal
Copy link
Member Author

@gpeuc We should wait for @eouin to confirm, but this was briefly discussed in team grooming -- we already locally store tags so that they are retained when the user reopens Knowledge Hub. But if there is something else we need to consider, Ed would definitely be the person for that :-)

@gpeuc
Copy link

gpeuc commented May 12, 2023

@eouin @cjbernal I'd like that we get some tech confirmation on how could this be done. Are we just saving IDs, and then when we render Fav tab we pull from Blogs those IDs in order to get title and other metadata. Or do we maybe have to save some of the metadata (hard-code save it) when users press the ⭐ button?

If it's as simple as us storing IDs, and based on those we can on-the-fly pull whatever we need from those entities, then we are good to go. But I'd like someone to confirm that is indeed the case.

I do see that we are using some IDs already to link to Blogs - https://blogs.sap.com/?p=1729704 - so is that it? We save 1729704 and we can later get everything from that?

@eouin
Copy link
Contributor

eouin commented May 16, 2023

@gpeuc At the moment we are saving an array of object made with id's and a description text. We can do the sane for favorite entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants