Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Viewer allows the JS embedded in the PDF to be executed #3946

Closed
madeleinezeng opened this issue Jan 10, 2024 · 2 comments
Closed

PDF Viewer allows the JS embedded in the PDF to be executed #3946

madeleinezeng opened this issue Jan 10, 2024 · 2 comments

Comments

@madeleinezeng
Copy link

madeleinezeng commented Jan 10, 2024

OpenUI5 version: 1.120.3

Browser/version (+device/version): Chrome 120.0.6099.130 (windows 11)

Any other tested browsers/devices(OK/FAIL): No

URL (minimal example if possible): N/A

Steps to reproduce the problem:

  1. Preview a PDF with embedded JS

What is the expected result?
The embedded JS is not executed, or the preview of the PDF is prevented, to avoid Stored XSS via PDF Injection

What happens instead?
The embedded JS is executed while previewing the PDF

Any other information? (attach screenshot if possible)

@boghyon
Copy link
Contributor

boghyon commented Jan 10, 2024

Unfortunately, security issues cannot be processed here according to https://github.com/SAP/openui5/blob/master/CONTRIBUTING.md#reporting-security-issues

Please follow the linked guideline.

@i556484 i556484 closed this as completed Jan 10, 2024
@boghyon
Copy link
Contributor

boghyon commented Jan 10, 2024

If the source of the PDF file cannot be trusted, keep the PDFViewer property isTrustedSource at false. The user has then the option to explicitly download the PDF file from the toolbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants