Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap.ui.qunit.utils.nextUIUpdate and waitForThemeApplied recommended as replacements, but not exposed #4074

Closed
LukasHeimann opened this issue Jun 21, 2024 · 2 comments

Comments

@LukasHeimann
Copy link

Prior to UI5 2.0, a couple of methods were deprecated. The jsdoc in OpenUI5, and thus TypeScript types as well as the UI5 linter expose the deprecation notices with hints to replace with alternatives from sap.ui.qunit.utils, i.e.

Indeed, those two methods are really useful when writing tests for custom controls. However, these methods are not exposed properly. nextUIUpdate is marked as @public, but waitForThemeApplied is not. Both are not shown on https://ui5.sap.com, and don't appear in the generated types, presumably due to deliberate exclusion at

<exclude name="sap.ui.qunit." />

This discussion started at SAP/ui5-typescript#459, but I was redirected here as the types are generated correctly, but the issue is the JSDoc and library configuration. Also, it was noted there that (until now) the two functions were deliberately not released (yet).

  • As a developer, I want to use the recommended replacements for deprecated public functionality in a compliant manner, and thus would like to have the recommended replacements publicly released and documented.
  • As a developer of custom controls, I'd like to use simple promise-based methods to wait for the execution environment to be in the right state -- this especially includes waiting for UI rerendering and themes being applied.

Thus, please consider properly exposing the two methods to end users, both in JSDoc as well as in TypeScript and https://ui5.sap.com.

Thank you very much for your support!
Lukas

@flovogt
Copy link
Member

flovogt commented Jun 26, 2024

Thanks a lot @LukasHeimann for reporting this issue. I have created an internal incident DINC0193814 and the respective team will update the status of the issue here in GitHub.

@LukasHeimann
Copy link
Author

Thank you for the fix, looking forward to updating to 1.127 in August!

@flovogt flovogt added fixed and removed in progress labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants