Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move B2B models from core to feature lib #8499

Closed
Platonn opened this issue Aug 7, 2020 · 1 comment · Fixed by #9280
Closed

Move B2B models from core to feature lib #8499

Platonn opened this issue Aug 7, 2020 · 1 comment · Fixed by #9280

Comments

@Platonn
Copy link
Contributor

Platonn commented Aug 7, 2020

Our very core model like Order were lately (in last 2 months) polluted with b2b-related properties (i.e. order.costCenter) . This prevents us from moving b2b-related types (i.e. CostCenter) from core to the feature lib, because core would depend then on the feature lib (Order would depend on CostCenter).

We see a hope in the ongoing ticket for Extensible types (aka Types augmentation) #7940

This will allow for keeping thin Order in the core lib, but in the my-account lib import this TS interface and re-declare it with adding new properties (like costCenter: CostCenter). Then the core lib won't depend on the my-account lib.

It's a follow up of #8423
Blocked by #7940

@Platonn Platonn added this to the 2.1 milestone Aug 7, 2020
@Platonn Platonn added this to BACKLOG in Feature: B2B My Company [Asterix] via automation Aug 7, 2020
@Platonn Platonn changed the title Move B2B types from core to feature lib Move B2B models from core to feature lib Aug 7, 2020
@Platonn Platonn moved this from BACKLOG to To Do in Feature: B2B My Company [Asterix] Aug 7, 2020
@Platonn Platonn moved this from To Do to Hold in Feature: B2B My Company [Asterix] Aug 7, 2020
@zebercut zebercut modified the milestones: 2.1, 3.0, MYCompany-MVP Aug 7, 2020
@Pucek9 Pucek9 moved this from Hold to To Do in Feature: B2B My Company [Asterix] Sep 3, 2020
@Platonn Platonn added the team/blamed Formerly known as Team Aimed and Team Framed; next it will be Team Famed? label Sep 3, 2020
@dunqan dunqan moved this from To Do to In Progress in Feature: B2B My Company [Asterix] Sep 9, 2020
@dunqan dunqan added this to To Do in Spartacus Tribe Board via automation Sep 9, 2020
@dunqan dunqan moved this from In Progress to To Do in Feature: B2B My Company [Asterix] Sep 9, 2020
@dunqan dunqan removed their assignment Oct 6, 2020
@marlass
Copy link
Contributor

marlass commented Oct 9, 2020

Actually Order is more of an checkout lib responsibility so it should not be moved to my-account. However this task still applies for other models that are primarly used in my-account and also needed in B2B Checkout. Then the my-account properties of those models should be moved there utilizing type augmentation.

plabadie added a commit that referenced this issue Oct 16, 2020
@Xymmer Xymmer modified the milestones: MVP-MyCompany, MVP-Approvals-MyCo Oct 19, 2020
@Pucek9 Pucek9 removed this from In Progress in Feature: B2B My Company [Asterix] Oct 19, 2020
@plabadie plabadie moved this from In Progress to Code Review & Local QA in Spartacus Tribe Board Oct 19, 2020
@plabadie plabadie moved this from Code Review & Local QA to In Progress in Spartacus Tribe Board Oct 19, 2020
@plabadie plabadie moved this from In Progress to Code Review & Local QA in Spartacus Tribe Board Oct 20, 2020
@Platonn Platonn self-assigned this Oct 23, 2020
WeizhengSap added a commit that referenced this issue Oct 29, 2020
@plabadie plabadie moved this from Code Review & Local QA to Merge to DEVELOP! in Spartacus Tribe Board Oct 30, 2020
@WeizhengSap WeizhengSap moved this from Merge to DEVELOP! to Done in Spartacus Tribe Board Oct 30, 2020
@Xymmer Xymmer modified the milestones: MVP-Approvals-MyCo, 3.0 Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

8 participants