-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move B2B models from core to feature lib #8499
Projects
Milestone
Comments
Platonn
changed the title
Move B2B types from core to feature lib
Move B2B models from core to feature lib
Aug 7, 2020
Platonn
added
the
team/blamed
Formerly known as Team Aimed and Team Framed; next it will be Team Famed?
label
Sep 3, 2020
Actually |
Platonn
added a commit
that referenced
this issue
Oct 14, 2020
plabadie
added a commit
that referenced
this issue
Oct 16, 2020
plabadie
added a commit
that referenced
this issue
Oct 16, 2020
plabadie
added
team/gladiators
and removed
team/blamed
Formerly known as Team Aimed and Team Framed; next it will be Team Famed?
labels
Oct 16, 2020
WeizhengSap
added a commit
that referenced
this issue
Oct 16, 2020
plabadie
moved this from In Progress
to Code Review & Local QA
in Spartacus Tribe Board
Oct 19, 2020
plabadie
added a commit
that referenced
this issue
Oct 19, 2020
plabadie
moved this from Code Review & Local QA
to In Progress
in Spartacus Tribe Board
Oct 19, 2020
marlass
added a commit
that referenced
this issue
Oct 20, 2020
plabadie
moved this from In Progress
to Code Review & Local QA
in Spartacus Tribe Board
Oct 20, 2020
plabadie
added a commit
that referenced
this issue
Oct 23, 2020
plabadie
added a commit
that referenced
this issue
Oct 26, 2020
WeizhengSap
added a commit
that referenced
this issue
Oct 29, 2020
WeizhengSap
added a commit
that referenced
this issue
Oct 29, 2020
WeizhengSap
added a commit
that referenced
this issue
Oct 29, 2020
WeizhengSap
added a commit
that referenced
this issue
Oct 29, 2020
WeizhengSap
added a commit
that referenced
this issue
Oct 30, 2020
plabadie
moved this from Code Review & Local QA
to Merge to DEVELOP!
in Spartacus Tribe Board
Oct 30, 2020
WeizhengSap
added a commit
that referenced
this issue
Oct 30, 2020
WeizhengSap
pushed a commit
that referenced
this issue
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our very core model like
Order
were lately (in last 2 months) polluted with b2b-related properties (i.e. order.costCenter) . This prevents us from moving b2b-related types (i.e. CostCenter) from core to the feature lib, because core would depend then on the feature lib (Order would depend on CostCenter).We see a hope in the ongoing ticket for Extensible types (aka Types augmentation) #7940
This will allow for keeping thin
Order
in the core lib, but in the my-account lib import this TS interface and re-declare it with adding new properties (likecostCenter: CostCenter
). Then the core lib won't depend on the my-account lib.It's a follow up of #8423
Blocked by #7940The text was updated successfully, but these errors were encountered: