Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] moduleBundler: Always default to optimize: true #685

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jan 18, 2022

bundleOptions are often omitted. So document them as optional and always
default 'optimize' to true, even if bundleOptions are specified.

This also fixes a bug that appeared if no 'bundleOptions' are defined in the ui5.yaml (e.g. sap.ui.webc.common).

@matz3 matz3 requested a review from RandomByte January 18, 2022 08:28
@coveralls
Copy link

coveralls commented Jan 18, 2022

Coverage Status

Coverage increased (+0.0007%) to 94.783% when pulling 21dbc71 on fix-generateBundle-task into 04072a2 on next.

@RandomByte RandomByte force-pushed the fix-generateBundle-task branch 2 times, most recently from 3174d3c to da1b137 Compare January 18, 2022 09:26
@RandomByte RandomByte marked this pull request as ready for review January 18, 2022 09:27
@RandomByte RandomByte changed the title [INTERNAL] Fix generateBundle task when bundleOptions are not passed [BREAKING] moduleBundler: Always default to optimize: true Jan 18, 2022
RandomByte
RandomByte previously approved these changes Jan 18, 2022
bundleOptions are often omitted. So document them as optional and always
default 'optimize' to true, even if bundleOptions are specified.
RandomByte
RandomByte previously approved these changes Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants